Re: [PATCH v15 08/23] LSM: Use lsmblob in security_ipc_getsecid

Paul Moore
2020-03-07T01:22:06Z

On Fri, Feb 21, 2020 at 7:05 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> There may be more than one LSM that provides IPC data
> for auditing. Change security_ipc_getsecid() to fill in
> a lsmblob structure instead of the u32 secid. The
> audit data structure containing the secid will be updated
> later, so there is a bit of scaffolding here.

"updated later", that's better, thank you. If I can go even a step
further, it would be really nice if you could provide a brief
explanation, a sentence or two is okay, on what you intended it to be
when it is done in this patchset/iteration.

> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: John Johansen <john.johansen@canonical.com>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
> include/linux/security.h | 7 ++++---
> kernel/auditsc.c | 5 ++++-
> security/security.c | 12 +++++++++---
> 3 files changed, 17 insertions(+), 7 deletions(-)

--
paul moore