From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C536CC63777 for ; Fri, 20 Nov 2020 13:54:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F5BD22272 for ; Fri, 20 Nov 2020 13:54:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F5BD22272 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-MN8_-aKAMGOQKZYUy1bY5Q-1; Fri, 20 Nov 2020 08:54:46 -0500 X-MC-Unique: MN8_-aKAMGOQKZYUy1bY5Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D74F4C73A0; Fri, 20 Nov 2020 13:54:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C085F60C05; Fri, 20 Nov 2020 13:54:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A08DF4E58F; Fri, 20 Nov 2020 13:54:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AKBxSjd014611 for ; Fri, 20 Nov 2020 06:59:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 01AB42026D48; Fri, 20 Nov 2020 11:59:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F189A2026D47 for ; Fri, 20 Nov 2020 11:59:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E5DB103B802 for ; Fri, 20 Nov 2020 11:59:25 +0000 (UTC) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-SyBHVmujPK-4Yjo2GPi9Eg-1; Fri, 20 Nov 2020 06:59:23 -0500 X-MC-Unique: SyBHVmujPK-4Yjo2GPi9Eg-1 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kg53v-0000wK-0F; Fri, 20 Nov 2020 11:58:47 +0000 Date: Fri, 20 Nov 2020 12:58:44 +0100 From: Christian Brauner To: Christoph Hellwig Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120115844.h732hi5p3ullzfvs@wittgenstein> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> <20201120091247.GA14894@infradead.org> MIME-Version: 1.0 In-Reply-To: <20201120091247.GA14894@infradead.org> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Fri, 20 Nov 2020 08:54:26 -0500 Cc: Phil Estes , Lennart Poettering , Mimi Zohar , James Bottomley , Andreas Dilger , containers@lists.linux-foundation.org, Tycho Andersen , "Darrick J. Wong" , James Morris , smbarber@chromium.org, linux-ext4@vger.kernel.org, Mrunal Patel , Serge Hallyn , Arnd Bergmann , Jann Horn , selinux@vger.kernel.org, Josh Triplett , linux-fsdevel@vger.kernel.org, Aleksa Sarai , Alexander Viro , Andy Lutomirski , OGAWA Hirofumi , Geoffrey Thomas , David Howells , John Johansen , Theodore Tso , Seth Forshee , Dmitry Kasatkin , Jonathan Corbet , linux-security-module@vger.kernel.org, linux-audit@redhat.com, "Eric W. Biederman" , linux-api@vger.kernel.org, Alban Crequy , linux-integrity@vger.kernel.org, St??phane Graber , Todd Kjos X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Nov 20, 2020 at 09:12:47AM +0000, Christoph Hellwig wrote: > On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > > Maybe you didn't see this or you're referring to xfstests but this > > series contains a >=4000 lines long test-suite that validates all core > > features with and without idmapped mounts. It's the last patch in this > > version of the series and it's located in: > > tools/testing/selftests/idmap_mounts. > > > > Everytime a filesystem is added this test-suite will be updated. We > > would perfer if this test would be shipped with the kernel itself and > > not in a separate test-suite such as xfstests. But we're happy to add > > patches for the latter at some point too. > > selftests is a complete pain to use, partialy because it is not > integrated with the framework we file system developers use (xfstests) > and partially because having the test suite in the kernel tree really > breaks a lot of the typical use cases. So I think we'll need to wire > this up in the proper place instead. Ok, I think I can basically port the test-suite at the end of this patch series so that it can be carried in xfstests/src/idmapped_mounts.c I'll start doing that now. It would make it a bit easier if we could carry it as a single file for now. Christian -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit