From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: john.johansen@canonical.com, kbuild-all@lists.01.org,
linux-audit@redhat.com
Subject: Re: [PATCH v27 22/25] Audit: Add record for multiple process LSM attributes
Date: Wed, 16 Jun 2021 18:33:36 +0800 [thread overview]
Message-ID: <202106161808.Ktzg5FJf-lkp@intel.com> (raw)
In-Reply-To: <20210611000435.36398-23-casey@schaufler-ca.com>
[-- Attachment #1: Type: text/plain, Size: 9364 bytes --]
Hi Casey,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
[also build test WARNING on linus/master v5.13-rc6]
[cannot apply to security/next-testing pcmoore-audit/next nf-next/master next-20210615]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d534cd725d8e262f150ea8c62bd452ae6d42bb19
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
git checkout d534cd725d8e262f150ea8c62bd452ae6d42bb19
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from kernel/audit.c:51:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/audit.c: In function 'audit_log_config_change':
kernel/audit.c:393:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'? [-Werror=implicit-function-declaration]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
>> kernel/audit.c:393:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_receive_msg':
kernel/audit.c:1358:13: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1358 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1381:13: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1381 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1399:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1399 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1431:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1431 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1505:12: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1505 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_log_multicast':
kernel/audit.c:1567:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1567 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: At top level:
kernel/audit.c:1789:14: warning: no previous prototype for 'audit_serial' [-Wmissing-prototypes]
1789 | unsigned int audit_serial(void)
| ^~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1937:2: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1937 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1946:3: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1946 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
kernel/audit.c: In function 'audit_log_set_loginuid':
kernel/audit.c:2334:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
2334 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
In file included from include/linux/perf_event.h:25,
from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:87,
from kernel/audit.c:44:
At top level:
arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
| ^~~~~~~~~~~~~~~~~
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
91 | static const char * const arc_pmu_ev_hw_map[] = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from kernel/auditfilter.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/auditfilter.c: In function 'audit_log_rule_change':
kernel/auditfilter.c:1107:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'? [-Werror=implicit-function-declaration]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
>> kernel/auditfilter.c:1107:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/integrity_audit.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/integrity_audit.c: In function 'integrity_audit_message':
security/integrity/integrity_audit.c:48:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_log_format'? [-Werror=implicit-function-declaration]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
>> security/integrity/integrity_audit.c:48:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/ima/ima.h:22,
from security/integrity/ima/ima_api.c:18:
include/linux/audit.h:571:1: error: expected identifier or '(' before '+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/ima/ima_api.c: In function 'ima_audit_measurement':
security/integrity/ima/ima_api.c:362:12: error: implicit declaration of function 'audit_alloc_for_lsm'; did you mean 'audit_log_format'? [-Werror=implicit-function-declaration]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
>> security/integrity/ima/ima_api.c:362:10: warning: assignment to 'struct audit_context *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
vim +393 kernel/audit.c
385
386 static int audit_log_config_change(char *function_name, u32 new, u32 old,
387 int allow_changes)
388 {
389 struct audit_context *context;
390 struct audit_buffer *ab;
391 int rc = 0;
392
> 393 context = audit_alloc_for_lsm(GFP_KERNEL);
394 ab = audit_log_start(context, GFP_KERNEL, AUDIT_CONFIG_CHANGE);
395 if (unlikely(!ab))
396 return rc;
397 audit_log_format(ab, "op=set %s=%u old=%u ", function_name, new, old);
398 audit_log_session_info(ab);
399 rc = audit_log_task_context(ab);
400 if (rc)
401 allow_changes = 0; /* Something weird, deny request */
402 audit_log_format(ab, " res=%d", allow_changes);
403 audit_log_end(ab);
404 audit_free_local(context);
405 return rc;
406 }
407
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68108 bytes --]
[-- Attachment #3: Type: text/plain, Size: 106 bytes --]
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-06-16 12:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210611000435.36398-1-casey.ref@schaufler-ca.com>
2021-06-11 0:04 ` [PATCH v27 00/25] LSM: Module stacking for AppArmor Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 01/25] LSM: Infrastructure management of the sock security Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 02/25] LSM: Add the lsmblob data structure Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 03/25] LSM: provide lsm name and id slot mappings Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 04/25] IMA: avoid label collisions with stacked LSMs Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 05/25] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 06/25] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 07/25] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 08/25] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 09/25] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 10/25] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 11/25] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 12/25] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 13/25] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 14/25] LSM: Specify which LSM to display Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 15/25] LSM: Ensure the correct LSM context releaser Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 16/25] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 17/25] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 18/25] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 19/25] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 20/25] LSM: Verify LSM display sanity in binder Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 21/25] audit: add support for non-syscall auxiliary records Casey Schaufler
2021-06-16 14:54 ` kernel test robot
2021-06-16 15:05 ` kernel test robot
2021-06-11 0:04 ` [PATCH v27 22/25] Audit: Add record for multiple process LSM attributes Casey Schaufler
2021-06-16 10:33 ` kernel test robot [this message]
2021-06-16 17:55 ` kernel test robot
2021-06-11 0:04 ` [PATCH v27 23/25] Audit: Add record for multiple object " Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 24/25] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2021-06-11 0:04 ` [PATCH v27 25/25] AppArmor: Remove the exclusive flag Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106161808.Ktzg5FJf-lkp@intel.com \
--to=lkp@intel.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox