From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9A0C83028 for ; Thu, 2 Sep 2021 17:04:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B278C61051 for ; Thu, 2 Sep 2021 17:04:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B278C61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630602272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Kdn/EzImVgR9u3Cm+IMApM4yfC4AwsOSDGQUN54XaCo=; b=YS9Hs8x7oDpTESKcRwRd+fvlrvbnj01Rrm7bxbZGTIRviDlNiMdfuX0qouhklnPHZ657cC 69r+u3CmRp89HGw7ho2yy9BUQZUTs1HjciY3p0dttV4QEHtSg/WLjPIGKoaX2/UZXTXy5P r5+Smn5wnQreZZH/CZA+qm+E1LK2b1E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-iZiyrG7AO-KHzo1X2SZcuA-1; Thu, 02 Sep 2021 13:04:31 -0400 X-MC-Unique: iZiyrG7AO-KHzo1X2SZcuA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0C3E1940925; Thu, 2 Sep 2021 17:04:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C9EC6715F; Thu, 2 Sep 2021 17:04:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 738A71809C98; Thu, 2 Sep 2021 17:04:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 182G8lNA016295 for ; Thu, 2 Sep 2021 12:08:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7518C9D62; Thu, 2 Sep 2021 16:08:47 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8976419C46; Thu, 2 Sep 2021 16:08:43 +0000 (UTC) Date: Thu, 2 Sep 2021 18:08:40 +0200 From: Eugene Syromiatnikov To: Cai Huoqing Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Message-ID: <20210902160840.GA2220@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210901160244.GA5957@asgard.redhat.com> <20210901165202.GA4518@asgard.redhat.com> <1797920.tdWV9SEqCh@x2> <20210902133529.GA32500@LAPTOP-UKSR4ENP.internal.baidu.com> MIME-Version: 1.0 In-Reply-To: <20210902133529.GA32500@LAPTOP-UKSR4ENP.internal.baidu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Thu, 02 Sep 2021 12:58:42 -0400 Cc: yoshfuji@linux-ipv6.org, linux-api@vger.kernel.org, dsahern@kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io, linux-audit@redhat.com, netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, strace development discussions X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Sep 02, 2021 at 09:35:29PM +0800, Cai Huoqing wrote: > On 01 Sep 21 13:36:54, Steve Grubb wrote: > > Hello, > > > > Thanks for the heads up. > > > > On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote: > > > Adding linux-audit, strace-devel, and linux-api to CC:. > > > > > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote: > > > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > > > > > commit <47595e32869f> ("") > > > > > indicated the ipx network layer as obsolete in Jan 2018, > > > > > updated in the MAINTAINERS file > > > > > > > > > > now, after being exposed for 3 years to refactoring, so to > > > > > delete uapi/linux/ipx.h and net/ipx.h header files for good. > > > > > additionally, there is no module that depends on ipx.h except > > > > > a broken staging driver(r8188eu) > > > > > > > > > > Signed-off-by: Cai Huoqing > > > > > > > > This removal breaks audit[1] and potentially breaks strace[2][3], at > > > > least. > > > > I wouldn't say breaks so much as needs coordination with. :-) If ipx is > > being dropped in its entirety, I can just make that part of the code > > conditional to the header existing. > > > > -Steve > IPX is marked obsolete for serveral years. so remove it and the > dependency in linux tree. > I'm sorry to not thinking about linux-audit and strace. > Might you remove the dependency or make the part of the code. > Many thanks. Unfortunately, that is not how UAPI works. That change breaks building of the existing code; one cannot change already released versions of either audit, strace, or any other userspace program that happens to unconditionally include without any fallback (like provided by glibc). > > -Cai > > > > > > [1] > > > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1 > > > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] > > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > > > d7106d6b/src/net.c#L34 [3] > > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > > > d7106d6b/src/sockaddr.c#L30 > > > > > > > > > -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit