Re: [PATCH v30 26/28] Audit: Add record for multiple object security contexts

kernel test robot
2021-11-24T14:23:17Z

Hi Casey,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]
[also build test ERROR on nf/master linus/master v5.16-rc2]
[cannot apply to pcmoore-audit/next jmorris-security/next-testing next-20211124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20211124-104307
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20211124/202111242114.1WN6oSkW-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3054c600afec9a016902ed6ed5de86c76d6b0105
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20211124-104307
git checkout 3054c600afec9a016902ed6ed5de86c76d6b0105
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from arch/powerpc/kernel/ptrace/ptrace.c:20:
include/linux/audit.h:262:1: error: expected identifier or '(' before '{' token
262 | { }
| ^
>> include/linux/audit.h:260:20: error: 'audit_log_object_context' declared 'static' but never defined [-Werror=unused-function]
260 | static inline void audit_log_object_context(struct audit_buffer *ab,
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

vim +260 include/linux/audit.h

220
221 #else /* CONFIG_AUDIT */
222 static inline __printf(4, 5)
223 void audit_log(struct audit_context *ctx, gfp_t gfp_mask, int type,
224 const char *fmt, ...)
225 { }
226 static inline struct audit_buffer *audit_log_start(struct audit_context *ctx,
227 gfp_t gfp_mask, int type)
228 {
229 return NULL;
230 }
231 static inline __printf(2, 3)
232 void audit_log_format(struct audit_buffer *ab, const char *fmt, ...)
233 { }
234 static inline void audit_log_end(struct audit_buffer *ab)
235 { }
236 static inline void audit_log_n_hex(struct audit_buffer *ab,
237 const unsigned char *buf, size_t len)
238 { }
239 static inline void audit_log_n_string(struct audit_buffer *ab,
240 const char *buf, size_t n)
241 { }
242 static inline void audit_log_n_untrustedstring(struct audit_buffer *ab,
243 const char *string, size_t n)
244 { }
245 static inline void audit_log_untrustedstring(struct audit_buffer *ab,
246 const char *string)
247 { }
248 static inline void audit_log_d_path(struct audit_buffer *ab,
249 const char *prefix,
250 const struct path *path)
251 { }
252 static inline void audit_log_key(struct audit_buffer *ab, char *key)
253 { }
254 static inline void audit_log_path_denied(int type, const char *operation)
255 { }
256 static inline int audit_log_task_context(struct audit_buffer *ab)
257 {
258 return 0;
259 }
> 260 static inline void audit_log_object_context(struct audit_buffer *ab,
261 struct lsmblob *blob);
262 { }
263 static inline void audit_log_task_info(struct audit_buffer *ab)
264 { }
265

---
0-DAY CI Kernel Test Service, Intel Corporation