From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 092CEC433F5 for ; Wed, 24 Nov 2021 14:22:52 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-TgZMTqfvOVyp4MtqFT8zKw-1; Wed, 24 Nov 2021 09:22:47 -0500 X-MC-Unique: TgZMTqfvOVyp4MtqFT8zKw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6692010199A1; Wed, 24 Nov 2021 14:22:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7742D794A3; Wed, 24 Nov 2021 14:22:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CBA1F1809C88; Wed, 24 Nov 2021 14:22:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AO7hmb6007614 for ; Wed, 24 Nov 2021 02:43:48 -0500 Received: by smtp.corp.redhat.com (Postfix) id 61FA24047279; Wed, 24 Nov 2021 07:43:48 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5DAE04047272 for ; Wed, 24 Nov 2021 07:43:48 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 456A6805C2F for ; Wed, 24 Nov 2021 07:43:48 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-334-fm0a8FfJNkGS4-IvxZqEhg-1; Wed, 24 Nov 2021 02:43:46 -0500 X-MC-Unique: fm0a8FfJNkGS4-IvxZqEhg-1 X-IronPort-AV: E=McAfee;i="6200,9189,10177"; a="233944940" X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="233944940" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2021 23:42:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="475031664" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 23 Nov 2021 23:42:38 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mpmvN-0004TV-85; Wed, 24 Nov 2021 07:42:37 +0000 Date: Wed, 24 Nov 2021 15:41:35 +0800 From: kernel test robot To: Casey Schaufler , casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v30 26/28] Audit: Add record for multiple object security contexts Message-ID: <202111241506.7V9kCQCo-lkp@intel.com> References: <20211124014332.36128-27-casey@schaufler-ca.com> MIME-Version: 1.0 In-Reply-To: <20211124014332.36128-27-casey@schaufler-ca.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Wed, 24 Nov 2021 09:20:44 -0500 Cc: john.johansen@canonical.com, kbuild-all@lists.01.org, linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Casey, I love your patch! Yet something to improve: [auto build test ERROR on nf-next/master] [also build test ERROR on nf/master linus/master v5.16-rc2] [cannot apply to pcmoore-audit/next next-20211124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20211124-104307 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20211124/202111241506.7V9kCQCo-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/3054c600afec9a016902ed6ed5de86c76d6b0105 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20211124-104307 git checkout 3054c600afec9a016902ed6ed5de86c76d6b0105 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from init/init_task.c:12: >> include/linux/audit.h:262:1: error: expected identifier or '(' before '{' token 262 | { } | ^ include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from kernel/exit.c:49: >> include/linux/audit.h:262:1: error: expected identifier or '(' before '{' token 262 | { } | ^ kernel/exit.c:1817:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes] 1817 | __weak void abort(void) | ^~~~~ In file included from kernel/exit.c:49: include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from fs/pipe.c:23: >> include/linux/audit.h:262:1: error: expected identifier or '(' before '{' token 262 | { } | ^ fs/pipe.c:755:15: warning: no previous prototype for 'account_pipe_buffers' [-Wmissing-prototypes] 755 | unsigned long account_pipe_buffers(struct user_struct *user, | ^~~~~~~~~~~~~~~~~~~~ fs/pipe.c:761:6: warning: no previous prototype for 'too_many_pipe_buffers_soft' [-Wmissing-prototypes] 761 | bool too_many_pipe_buffers_soft(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:768:6: warning: no previous prototype for 'too_many_pipe_buffers_hard' [-Wmissing-prototypes] 768 | bool too_many_pipe_buffers_hard(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:775:6: warning: no previous prototype for 'pipe_is_unprivileged_user' [-Wmissing-prototypes] 775 | bool pipe_is_unprivileged_user(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:1245:5: warning: no previous prototype for 'pipe_resize_ring' [-Wmissing-prototypes] 1245 | int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots) | ^~~~~~~~~~~~~~~~ In file included from fs/pipe.c:23: include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +262 include/linux/audit.h 220 221 #else /* CONFIG_AUDIT */ 222 static inline __printf(4, 5) 223 void audit_log(struct audit_context *ctx, gfp_t gfp_mask, int type, 224 const char *fmt, ...) 225 { } 226 static inline struct audit_buffer *audit_log_start(struct audit_context *ctx, 227 gfp_t gfp_mask, int type) 228 { 229 return NULL; 230 } 231 static inline __printf(2, 3) 232 void audit_log_format(struct audit_buffer *ab, const char *fmt, ...) 233 { } 234 static inline void audit_log_end(struct audit_buffer *ab) 235 { } 236 static inline void audit_log_n_hex(struct audit_buffer *ab, 237 const unsigned char *buf, size_t len) 238 { } 239 static inline void audit_log_n_string(struct audit_buffer *ab, 240 const char *buf, size_t n) 241 { } 242 static inline void audit_log_n_untrustedstring(struct audit_buffer *ab, 243 const char *string, size_t n) 244 { } 245 static inline void audit_log_untrustedstring(struct audit_buffer *ab, 246 const char *string) 247 { } 248 static inline void audit_log_d_path(struct audit_buffer *ab, 249 const char *prefix, 250 const struct path *path) 251 { } 252 static inline void audit_log_key(struct audit_buffer *ab, char *key) 253 { } 254 static inline void audit_log_path_denied(int type, const char *operation) 255 { } 256 static inline int audit_log_task_context(struct audit_buffer *ab) 257 { 258 return 0; 259 } 260 static inline void audit_log_object_context(struct audit_buffer *ab, 261 struct lsmblob *blob); > 262 { } 263 static inline void audit_log_task_info(struct audit_buffer *ab) 264 { } 265 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit