From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3966FC433F5 for ; Mon, 6 Dec 2021 22:15:21 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-mKp4KDp4PTGhARtd7vVQ9w-1; Mon, 06 Dec 2021 17:15:17 -0500 X-MC-Unique: mKp4KDp4PTGhARtd7vVQ9w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2002B193F56C; Mon, 6 Dec 2021 22:15:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F70B196E6; Mon, 6 Dec 2021 22:15:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0EF9D4BB7C; Mon, 6 Dec 2021 22:15:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B6748sW005384 for ; Mon, 6 Dec 2021 02:04:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id B249F1402427; Mon, 6 Dec 2021 07:04:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADEFD140EBFE for ; Mon, 6 Dec 2021 07:04:08 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92DC985A5A8 for ; Mon, 6 Dec 2021 07:04:08 +0000 (UTC) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-57KHc7fvPVihYeasQ4wIGA-1; Mon, 06 Dec 2021 02:04:06 -0500 X-MC-Unique: 57KHc7fvPVihYeasQ4wIGA-1 Received: by mail-pf1-f181.google.com with SMTP id x131so9281071pfc.12 for ; Sun, 05 Dec 2021 23:04:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HXwTAzkvUDjhhLa3JIAth4980gr9mc2XPQgpC9SXV2k=; b=w8hmYPtgDU5Nos/OWkqylD7YS4T6EGvWxQCFLBvBJJYfS1nw7Xtm1jE53GXCLsdJC6 Q5VWS2ofrNyOaClMbH6HJdO+DTRh7a06BHkXb3oiP/Udt1ULhw2pYAwkXTS1WLna50C1 GUHPeaz+Jud3eW/tdQdE0uEo5nQ2ofYy9cPeqwxrfsIh9p9NH0IEJH7jkvMWb4D11eg0 bxlSQRy8nddq9taGlvHgG0CQvXXzDnTUDfmji/9QbBHMXadYj/roeT80u6GVFsF0DfXd AweMp8BXAuErdtx5ntnP13VBlqEHrAi/tr4iN9stVqUZ3EU9TRGp5NMryTnyMraxAkE7 2waQ== X-Gm-Message-State: AOAM531bdnqJm9VYTR9oBjd9pozZaupjj0vgzT8QR3ndefKJLr0U9gU/ /wkNf/rd2MA0oiaTPa9zd/CoLQ== X-Google-Smtp-Source: ABdhPJzjLMthv5mO34i8EfRiYH7pph+S6Wp1Hk+X2XlKJmVy4wOGI/LF8C4azzeCKwWqapJQc8mjhQ== X-Received: by 2002:a63:8749:: with SMTP id i70mr17421400pge.511.1638774245629; Sun, 05 Dec 2021 23:04:05 -0800 (PST) Received: from leoy-ThinkPad-X240s (104.225.157.100.16clouds.com. [104.225.157.100]) by smtp.gmail.com with ESMTPSA id nh21sm9357961pjb.30.2021.12.05.23.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Dec 2021 23:04:05 -0800 (PST) Date: Mon, 6 Dec 2021 15:03:58 +0800 From: Leo Yan To: Leon Romanovsky Subject: Re: [PATCH v1 1/7] pid: Introduce helper task_is_in_root_ns() Message-ID: <20211206070358.GC42658@leoy-ThinkPad-X240s> References: <20211205145105.57824-1-leo.yan@linaro.org> <20211205145105.57824-2-leo.yan@linaro.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Mon, 06 Dec 2021 17:15:10 -0500 Cc: codalist@telemann.coda.cs.cmu.edu, Jan Harkes , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , netdev@vger.kernel.org, Balbir Singh , linux-kernel@vger.kernel.org, Eric Paris , coda@cs.cmu.edu, linux-audit@redhat.com, coresight@lists.linaro.org, Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Mike Leach X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Leon, On Mon, Dec 06, 2021 at 08:49:01AM +0200, Leon Romanovsky wrote: > On Sun, Dec 05, 2021 at 10:50:59PM +0800, Leo Yan wrote: [...] > > +static inline bool task_is_in_root_ns(struct task_struct *tsk) > > It is bad that this name doesn't reflect PID nature of this namespace. > Won't it better to name it task_is_in_init_pid_ns()? Yes, task_is_in_init_pid_ns() is more clear. Will respin for this. Thank you for suggestion! Leo -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit