From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC516C433EF for ; Fri, 8 Apr 2022 12:51:01 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-EfDpZ-o_NxWerNaMtLgiUw-1; Fri, 08 Apr 2022 08:50:57 -0400 X-MC-Unique: EfDpZ-o_NxWerNaMtLgiUw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D83033820F63; Fri, 8 Apr 2022 12:50:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E632145B991; Fri, 8 Apr 2022 12:50:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C6144194034D; Fri, 8 Apr 2022 12:50:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F3FB21940340 for ; Fri, 8 Apr 2022 04:45:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CE4B71410F3B; Fri, 8 Apr 2022 04:45:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA564140EBD5 for ; Fri, 8 Apr 2022 04:45:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A65581C05AEB for ; Fri, 8 Apr 2022 04:45:26 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-29-1vttrQ9XMgif-Kpd0l3opg-1; Fri, 08 Apr 2022 00:45:24 -0400 X-MC-Unique: 1vttrQ9XMgif-Kpd0l3opg-1 X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="249038379" X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; d="scan'208";a="249038379" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 21:45:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; d="scan'208";a="723248260" Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 07 Apr 2022 21:45:20 -0700 Received: from kbuild by a44fdfb70b94 with local (Exim 4.95) (envelope-from ) id 1ncgUp-00062R-Ff; Fri, 08 Apr 2022 04:45:19 +0000 Date: Fri, 8 Apr 2022 12:44:29 +0800 From: kernel test robot To: Casey Schaufler , casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v34 11/29] LSM: Use lsmblob in security_current_getsecid Message-ID: <202204081233.FUUgdt5c-lkp@intel.com> References: <20220407212230.12893-12-casey@schaufler-ca.com> MIME-Version: 1.0 In-Reply-To: <20220407212230.12893-12-casey@schaufler-ca.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mailman-Approved-At: Fri, 08 Apr 2022 12:50:53 +0000 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: john.johansen@canonical.com, kbuild-all@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-audit@redhat.com, linux-integrity@vger.kernel.org Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Casey, I love your patch! Perhaps something to improve: [auto build test WARNING on pcmoore-selinux/next] [also build test WARNING on linus/master v5.18-rc1 next-20220407] [cannot apply to pcmoore-audit/next jmorris-security/next-testing] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220408-062243 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next config: mips-randconfig-r002-20220408 (https://download.01.org/0day-ci/archive/20220408/202204081233.FUUgdt5c-lkp@intel.com/config) compiler: mips64el-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0d4df6ae86e123057cb18eeb5ba1b1eff2641fe4 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220408-062243 git checkout 0d4df6ae86e123057cb18eeb5ba1b1eff2641fe4 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash security/integrity/ima/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): security/integrity/ima/ima_main.c: In function 'ima_file_check': >> security/integrity/ima/ima_main.c:521:16: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 521 | return process_measurement(file, current_cred(), blob.secid[0], NULL, 0, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 522 | mask & (MAY_READ | MAY_WRITE | MAY_EXEC | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 523 | MAY_APPEND), FILE_CHECK); | ~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:517:24: note: defined here 'blob' 517 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'ima_file_mmap': security/integrity/ima/ima_main.c:413:24: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 413 | return process_measurement(file, current_cred(), blob.secid[0], | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 414 | NULL, 0, MAY_EXEC, MMAP_CHECK); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:408:24: note: defined here 'blob' 408 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'ima_file_mprotect': security/integrity/ima/ima_main.c:453:18: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 453 | action = ima_get_action(file_mnt_user_ns(vma->vm_file), inode, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 454 | current_cred(), blob.secid[0], MAY_EXEC, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 455 | MMAP_CHECK, &pcr, &template, NULL, NULL); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:441:24: note: defined here 'blob' 441 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'ima_bprm_check': security/integrity/ima/ima_main.c:495:15: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 495 | ret = process_measurement(bprm->file, current_cred(), blob.secid[0], | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 496 | NULL, 0, MAY_EXEC, BPRM_CHECK); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:491:24: note: defined here 'blob' 491 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'ima_read_file': security/integrity/ima/ima_main.c:739:16: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 739 | return process_measurement(file, current_cred(), blob.secid[0], NULL, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 740 | 0, MAY_READ, func); | ~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:717:24: note: defined here 'blob' 717 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'ima_post_read_file': security/integrity/ima/ima_main.c:783:16: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 783 | return process_measurement(file, current_cred(), blob.secid[0], buf, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 784 | size, MAY_READ, func); | ~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:768:24: note: defined here 'blob' 768 | struct lsmblob blob; | ^~~~ security/integrity/ima/ima_main.c: In function 'process_buffer_measurement': security/integrity/ima/ima_main.c:934:26: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 934 | action = ima_get_action(mnt_userns, inode, current_cred(), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 935 | blob.secid[0], 0, func, &pcr, &template, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 936 | func_data, NULL); | ~~~~~~~~~~~~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_main.c:26: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_main.c:909:24: note: defined here 'blob' -- security/integrity/ima/ima_appraise.c: In function 'ima_must_appraise': >> security/integrity/ima/ima_appraise.c:81:16: warning: array subscript 0 is outside array bounds of 'u32[0]' {aka 'unsigned int[]'} [-Warray-bounds] 81 | return ima_match_policy(mnt_userns, inode, current_cred(), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 82 | blob.secid[0], func, mask, | ~~~~~~~~~~~~~~~~~~~~~~~~~~ 83 | IMA_APPRAISE | IMA_HASH, NULL, NULL, NULL, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 84 | NULL); | ~~~~~ In file included from include/linux/ima.h:12, from security/integrity/ima/ima_appraise.c:14: include/linux/security.h:150:17: note: while referencing 'secid' 150 | u32 secid[LSMBLOB_ENTRIES]; | ^~~~~ security/integrity/ima/ima_appraise.c:74:24: note: defined here 'blob' 74 | struct lsmblob blob; | ^~~~ vim +521 security/integrity/ima/ima_main.c 504 505 /** 506 * ima_file_check - based on policy, collect/store measurement. 507 * @file: pointer to the file to be measured 508 * @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND 509 * 510 * Measure files based on the ima_must_measure() policy decision. 511 * 512 * On success return 0. On integrity appraisal error, assuming the file 513 * is in policy and IMA-appraisal is in enforcing mode, return -EACCES. 514 */ 515 int ima_file_check(struct file *file, int mask) 516 { 517 struct lsmblob blob; 518 519 security_current_getsecid_subj(&blob); 520 /* scaffolding until process_measurement changes */ > 521 return process_measurement(file, current_cred(), blob.secid[0], NULL, 0, 522 mask & (MAY_READ | MAY_WRITE | MAY_EXEC | 523 MAY_APPEND), FILE_CHECK); 524 } 525 EXPORT_SYMBOL_GPL(ima_file_check); 526 -- 0-DAY CI Kernel Test Service https://01.org/lkp -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit