From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B1DEC433F5 for ; Tue, 3 May 2022 16:05:19 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-79-hV0lafAnPsGh2H3V9lq2gg-1; Tue, 03 May 2022 12:05:09 -0400 X-MC-Unique: hV0lafAnPsGh2H3V9lq2gg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E9DB18F0273; Tue, 3 May 2022 16:05:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0643D463BCD; Tue, 3 May 2022 16:05:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 632481947074; Tue, 3 May 2022 16:05:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8E8811947043 for ; Tue, 3 May 2022 14:15:55 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7D805C27EB5; Tue, 3 May 2022 14:15:55 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79B32C27EB0 for ; Tue, 3 May 2022 14:15:55 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F8EE1730498 for ; Tue, 3 May 2022 14:15:55 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-203-mpg7w8d4PzCHB_tjomS55g-5; Tue, 03 May 2022 10:15:29 -0400 X-MC-Unique: mpg7w8d4PzCHB_tjomS55g-5 X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="254946550" X-IronPort-AV: E=Sophos;i="5.91,195,1647327600"; d="scan'208";a="254946550" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 07:04:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,195,1647327600"; d="scan'208";a="692202842" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 03 May 2022 07:04:45 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nlt8u-000AWV-LM; Tue, 03 May 2022 14:04:44 +0000 Date: Tue, 3 May 2022 22:04:32 +0800 From: kernel test robot To: Sven Schnelle , Paul Moore , Eric Paris Subject: Re: [PATCH 1/2] audit: add call argument to socketcall auditing Message-ID: <202205032153.9OyzkwPS-lkp@intel.com> References: <20220503090212.1322050-1-svens@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <20220503090212.1322050-1-svens@linux.ibm.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mailman-Approved-At: Tue, 03 May 2022 16:05:03 +0000 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-audit@redhat.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Sven, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on pcmoore-audit/next v5.18-rc5 next-20220503] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Sven-Schnelle/audit-add-call-argument-to-socketcall-auditing/20220503-170442 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9050ba3a61a4b5bd84c2cde092a100404f814f31 config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220503/202205032153.9OyzkwPS-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/b89caaec1c1bd3382c6cef08d08beadbaf808513 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sven-Schnelle/audit-add-call-argument-to-socketcall-auditing/20220503-170442 git checkout b89caaec1c1bd3382c6cef08d08beadbaf808513 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): net/compat.c: In function '__do_compat_sys_socketcall': >> net/compat.c:440:49: warning: passing argument 2 of 'audit_socketcall_compat' makes pointer from integer without a cast [-Wint-conversion] 440 | ret = audit_socketcall_compat(call, len / sizeof(a[0]), a); | ~~~~^~~~~~~~~~~~~~ | | | long unsigned int In file included from net/compat.c:26: include/linux/audit.h:648:59: note: expected 'u32 *' {aka 'unsigned int *'} but argument is of type 'long unsigned int' 648 | static inline int audit_socketcall_compat(int nargs, u32 *args) | ~~~~~^~~~ >> net/compat.c:440:15: error: too many arguments to function 'audit_socketcall_compat' 440 | ret = audit_socketcall_compat(call, len / sizeof(a[0]), a); | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from net/compat.c:26: include/linux/audit.h:648:19: note: declared here 648 | static inline int audit_socketcall_compat(int nargs, u32 *args) | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/audit_socketcall_compat +440 net/compat.c 423 424 COMPAT_SYSCALL_DEFINE2(socketcall, int, call, u32 __user *, args) 425 { 426 u32 a[AUDITSC_ARGS]; 427 unsigned int len; 428 u32 a0, a1; 429 int ret; 430 431 if (call < SYS_SOCKET || call > SYS_SENDMMSG) 432 return -EINVAL; 433 len = nas[call]; 434 if (len > sizeof(a)) 435 return -EINVAL; 436 437 if (copy_from_user(a, args, len)) 438 return -EFAULT; 439 > 440 ret = audit_socketcall_compat(call, len / sizeof(a[0]), a); -- 0-DAY CI Kernel Test Service https://01.org/lkp -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit