From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8A7FC00140 for ; Thu, 11 Aug 2022 01:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660180826; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZvyjC8211NEG/yXZXZfJjaVSpFKjRygDzTwEKQN46Nk=; b=UxgIXUwhfLJQhfIeMian1RJutfPNeP+IlAO/oay3CM+SFuX59Bn+OJEaOmoXzsxEogDLAF /vMenQktx+Vn8Vz8HR7VIh21rPWDlLN9YgOnGtRAnsllFN0onSliOksZFhDxd0qDNG8JiL YE/i5zytXBqEcnBUF1/gQVUX+wrGVWg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-151-IvYiv2YbP2-1SRGzE_gNYA-1; Wed, 10 Aug 2022 21:20:23 -0400 X-MC-Unique: IvYiv2YbP2-1SRGzE_gNYA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95D4985A587; Thu, 11 Aug 2022 01:20:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87F892166B29; Thu, 11 Aug 2022 01:20:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 509F31946A5C; Thu, 11 Aug 2022 01:20:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D35BC1946A4F for ; Wed, 10 Aug 2022 20:34:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9364DC15BA8; Wed, 10 Aug 2022 20:34:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FC63C15BA9 for ; Wed, 10 Aug 2022 20:34:14 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 746AF3806648 for ; Wed, 10 Aug 2022 20:34:14 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-GbFn7nRDMOS3_LXzqRycYg-1; Wed, 10 Aug 2022 16:34:13 -0400 X-MC-Unique: GbFn7nRDMOS3_LXzqRycYg-1 X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="289942264" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="289942264" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 13:33:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="781360516" Received: from lkp-server02.sh.intel.com (HELO 5d6b42aa80b8) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 10 Aug 2022 13:33:06 -0700 Received: from kbuild by 5d6b42aa80b8 with local (Exim 4.96) (envelope-from ) id 1oLsO1-0000h3-1e; Wed, 10 Aug 2022 20:33:05 +0000 Date: Thu, 11 Aug 2022 04:32:15 +0800 From: kernel test robot To: Richard Guy Briggs , Linux-Audit Mailing List , LKML , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response Message-ID: <202208110406.Lb3ONrcP-lkp@intel.com> References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mailman-Approved-At: Thu, 11 Aug 2022 01:20:18 +0000 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amir Goldstein , kbuild-all@lists.01.org, Richard Guy Briggs , Jan Kara , llvm@lists.linux.dev, Eric Paris Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Richard, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on jack-fs/fsnotify] [also build test WARNING on pcmoore-audit/next linus/master v5.19 next-20220810] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Richard-Guy-Briggs/fanotify-Allow-user-space-to-pass-back-additional-audit-info/20220810-012825 base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220811/202208110406.Lb3ONrcP-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/bee8cac0b7796a753948c83b403a152f8c6acb8c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Richard-Guy-Briggs/fanotify-Allow-user-space-to-pass-back-additional-audit-info/20220810-012825 git checkout bee8cac0b7796a753948c83b403a152f8c6acb8c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/auditsc.c:2907:8: warning: variable 'ib' set but not used [-Wunused-but-set-variable] char *ib = buf; ^ 1 warning generated. vim +/ib +2907 kernel/auditsc.c 2902 2903 void __audit_fanotify(u32 response, size_t len, char *buf) 2904 { 2905 struct fanotify_response_info_audit_rule *friar; 2906 size_t c = len; > 2907 char *ib = buf; 2908 2909 if (!(len && buf)) { 2910 audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY, 2911 "resp=%u fan_type=0 fan_info=?", response); 2912 return; 2913 } 2914 while (c >= sizeof(struct fanotify_response_info_header)) { 2915 friar = (struct fanotify_response_info_audit_rule *)buf; 2916 switch (friar->hdr.type) { 2917 case FAN_RESPONSE_INFO_AUDIT_RULE: 2918 if (friar->hdr.len < sizeof(*friar)) { 2919 audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY, 2920 "resp=%u fan_type=%u fan_info=(incomplete)", 2921 response, friar->hdr.type); 2922 return; 2923 } 2924 audit_log(audit_context(), GFP_KERNEL, AUDIT_FANOTIFY, 2925 "resp=%u fan_type=%u fan_info=%u", 2926 response, friar->hdr.type, friar->audit_rule); 2927 } 2928 c -= friar->hdr.len; 2929 ib += friar->hdr.len; 2930 } 2931 } 2932 -- 0-DAY CI Kernel Test Service https://01.org/lkp -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit