From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E452DC433FE for ; Mon, 7 Dec 2020 23:28:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 577BA2388C for ; Mon, 7 Dec 2020 23:28:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 577BA2388C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607383724; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dk+OB6XVuiOYV3+zXCPbRg/h8F+cL2Sw3Yf80ei/HPE=; b=Gl1QH80dSkhw2ShKCbBgy4+r+oCEVa530qSHD3XkFuo3ih8VWpwVzhpyybdDMbn6+7ubTk wRmFPmtHDfndluadKMOkUjZcey5ROzBLt9VcmK//ovS8yHMIBq21gBXpcLN7hiy3yk+ZtV 816yS3B/3W0mGMEu46bnLiC0D1t2ARo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-MTiURzifOPGvUdrrnM9Y6A-1; Mon, 07 Dec 2020 18:28:42 -0500 X-MC-Unique: MTiURzifOPGvUdrrnM9Y6A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 162129CC03; Mon, 7 Dec 2020 23:28:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D8C82BFF1; Mon, 7 Dec 2020 23:28:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 51347180954D; Mon, 7 Dec 2020 23:28:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B7NSVfi003491 for ; Mon, 7 Dec 2020 18:28:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 90D702BFF1; Mon, 7 Dec 2020 23:28:31 +0000 (UTC) Received: from x2.localnet (ovpn-113-152.rdu2.redhat.com [10.10.113.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCB1360636; Mon, 7 Dec 2020 23:28:24 +0000 (UTC) From: Steve Grubb To: Max Englander Subject: Re: [PATCH v2] audit: report audit wait metric in audit status reply Date: Mon, 07 Dec 2020 18:28:22 -0500 Message-ID: <2046910.irdbgypaU6@x2> Organization: Red Hat In-Reply-To: References: <20200701213244.GA1817@linux-kernel-dev> <20201207212100.GN986374@madcap2.tricolour.ca> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: linux-audit@redhat.com Cc: Richard Guy Briggs , linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello Max, On Monday, December 7, 2020 4:28:14 PM EST Max Englander wrote: > Steve, I'm happy to make changes to the userspace PR based on > Richard's suggestions, if that sounds good to you. I'll follow up in > the PR to discuss it more The only issue is new userspace on old kernel. I think if we use both the configure macro in addition to a size check, then it will at least allow forward and backward compatibility. Other metrics would be good. I'd like to see a max_backlog to know if we are wasting memory. It would just record the highwater mark since auditing was enabled. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit