public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: Questions about --with-alpha and --with-armeb configure flags
Date: Mon, 26 Nov 2012 12:40:05 -0500	[thread overview]
Message-ID: <2472818.UVczZhjD93@x2> (raw)
In-Reply-To: <1614990143.37889188.1353950515505.JavaMail.root@redhat.com>

On Monday, November 26, 2012 12:21:55 PM Miloslav Trmac wrote:
> ----- Original Message -----
> 
> > > If I understand correctly it's only adding arch detection and syscall
> > > tables to ausyscall. Why are these syscall table conditional?
> > 
> > To reduce the number of text relocations in libaudit. Libaudit links
> > against a number of applications and text relocations eats memory and
> > increases startup time.
> 
> Is that really an issue with the current code?  The gentab.c code was
> designed to avoid text relocations.

I guess not

# relinfo.pl /lib64/libaudit.so.1.0.0 
/lib64/libaudit.so.1.0.0: 45 relocations, 35 relative (77%), 60 PLT entries, 2 
for local syms (3%), 97 users

# relinfo.pl /home/sgrubb/working/BUILD/audit/lib/.libs/libaudit.so.1.0.0 
/home/sgrubb/working/BUILD/audit/lib/.libs/libaudit.so.1.0.0: 45 relocations, 
35 relative (77%), 56 PLT entries, 2 for local syms (3%), 0 users

However, it does trim about 14k off libaudit by not compiling these in.


> At least on x86_64 (which, true, is especially well-designed for this),
> there are no text relocations in libaudit nor libauparse, whether
> --with-alpha or --with-armeb are used or not.  In fact the number of
> relocations of any kind is exactly the same in both cases.
> 
> Any one care to retest this on a different architecture, e.t. 32-bit x86?
> 
> FWIW, at least the attached patch was necessary to build with --with-alpha
> --with-armeb.

Applied. Thanks.

-Steve

  reply	other threads:[~2012-11-26 17:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 17:00 Questions about --with-alpha and --with-armeb configure flags Laurent Bigonville
2012-11-16 18:21 ` Steve Grubb
2012-11-16 19:00   ` Nathaniel Husted
2012-11-26 17:21   ` Miloslav Trmac
2012-11-26 17:40     ` Steve Grubb [this message]
2012-11-26 17:50     ` Nathaniel Husted
2012-11-30 13:42     ` Laurent Bigonville
2012-11-30 14:05       ` Steve Grubb
2012-11-30 17:41         ` Laurent Bigonville
2012-11-30 17:44           ` Miloslav Trmac
2012-12-01 14:38             ` Laurent Bigonville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2472818.UVczZhjD93@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=mitr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox