From: Paul Moore <paul@paul-moore.com>
To: Steve Grubb <sgrubb@redhat.com>,
linux-audit@redhat.com,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
rgb@redhat.com
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TaskTracker : Simplified thread information tracker.
Date: Mon, 12 Jan 2015 15:51:58 -0500 [thread overview]
Message-ID: <2562166.o5FKhBijgA@sifl> (raw)
In-Reply-To: <14076510.2zuEr3QEsx@x2>
On Monday, January 12, 2015 10:14:34 AM Steve Grubb wrote:
> On Monday, January 12, 2015 03:13:12 PM Tetsuo Handa wrote:
> > This record contains multiple user-influenced comm names. If I use
> > audit_log_untrustedstring(), I would need to split this record into
> > multiple records like history[0]='...' history[1]='...' history[2]='...'
> > in order to avoid matching delimiters (i.e. ';', '=' and '>') used in
> > this record.
>
> That sounds like a good change to me. Audit records are always name=value
> with a space between fields. We need this to always stay like this because
> the tooling expects that format. There is nowhere in the audit logs we use
> =>.
As a FYI, I'm putting a hold on any new audit messages for the time being so
we can evaluate the current kernel audit API to determine the possibility of
transitioning to a less ugly API. I'll leave the door open for messages
needed to fix bugs, but that's it. If we do end up providing a new API and
record format, I want to limit the number of message types in the existing
API.
My apologies, but this is long overdue and the longer we wait the more
difficult it will become.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2015-01-12 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 12:44 [PATCH] TaskTracker : Simplified thread information tracker Tetsuo Handa
2014-06-23 12:14 ` Tetsuo Handa
2014-06-24 14:00 ` Steve Grubb
2014-06-26 11:40 ` Tetsuo Handa
2014-09-27 1:02 ` Tetsuo Handa
2014-09-27 13:14 ` Steve Grubb
2014-09-27 15:13 ` Tetsuo Handa
2014-09-27 15:40 ` Steve Grubb
2014-09-28 10:24 ` [PATCH] audit: Emit history of thread's comm name Tetsuo Handa
2014-10-07 21:30 ` [PATCH] TaskTracker : Simplified thread information tracker Richard Guy Briggs
2014-10-10 12:40 ` Tetsuo Handa
2014-10-10 12:49 ` Richard Guy Briggs
2015-01-04 11:50 ` Tetsuo Handa
2015-01-05 18:07 ` Richard Guy Briggs
2015-01-12 6:13 ` Tetsuo Handa
2015-01-12 15:14 ` Steve Grubb
2015-01-12 20:51 ` Paul Moore [this message]
2015-01-20 13:20 ` Tetsuo Handa
2015-01-12 15:21 ` Richard Guy Briggs
2015-01-19 15:25 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2562166.o5FKhBijgA@sifl \
--to=paul@paul-moore.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox