From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EDCC433FE for ; Tue, 8 Dec 2020 13:45:01 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CA5E23A53 for ; Tue, 8 Dec 2020 13:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CA5E23A53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607435099; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jFSEQzIOrVV+hOhJ8PC16ibXC+x76d/zBfaI9P1KuzQ=; b=ILqfBhmlgUdxb/e5y6u7dnaURoSHwGWJADA9i7DRGJQ3TL0VZRl05UHmA/p0jjZTT1TXtI szJVKdCz7Q6LHqIo42kxFuNGuIhVkgxAroGVeEYZ6vxs7yEgsf6B4uKrMyP1V4PaLwOfAa dREJIcPReEG4vwc0qN32wyKznMcFI0Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-9V6nhAbJORO6D3EKzyUgdA-1; Tue, 08 Dec 2020 08:44:57 -0500 X-MC-Unique: 9V6nhAbJORO6D3EKzyUgdA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6834107ACE6; Tue, 8 Dec 2020 13:44:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AB1560877; Tue, 8 Dec 2020 13:44:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 17698180954D; Tue, 8 Dec 2020 13:44:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B8Diqo8019932 for ; Tue, 8 Dec 2020 08:44:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id 50D8D19D9B; Tue, 8 Dec 2020 13:44:52 +0000 (UTC) Received: from x2.localnet (ovpn-113-157.rdu2.redhat.com [10.10.113.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id B092519D9D; Tue, 8 Dec 2020 13:44:45 +0000 (UTC) From: Steve Grubb To: Richard Guy Briggs Subject: Re: [PATCH v2] audit: report audit wait metric in audit status reply Date: Tue, 08 Dec 2020 08:44:43 -0500 Message-ID: <2563857.mvXUDI8C0e@x2> Organization: Red Hat In-Reply-To: <20201208132003.GW1762914@madcap2.tricolour.ca> References: <20200701213244.GA1817@linux-kernel-dev> <5414845.DvuYhMxLoT@x2> <20201208132003.GW1762914@madcap2.tricolour.ca> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tuesday, December 8, 2020 8:20:03 AM EST Richard Guy Briggs wrote: > > > By configure macro are you talking about the presence of that audit > > > status mask bit, or the presence of that struct audit_status member? > > > > Yes. But it doesn't apply to old kernels. > > An "or" question usually needs one or the other reply unless both are > true... Which one were you talking about? Either. You shouldn't have one without the other. We just need to handle old user space/new kernel & new userspace/old kernel gracefully. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit