From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7704C64E7A for ; Thu, 3 Dec 2020 13:32:59 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C5B20449 for ; Thu, 3 Dec 2020 13:32:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C5B20449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607002377; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VlU+pTZcytvuVqViKIzOnBn1tbZgjNPtmP3pLAgQZHY=; b=Qj0hy2Kbxf0WWwAkgQL77V9w/7+yuO7x14YrCLdT9QNreAXNqZpd1fCskba5T1SfoSvY+p cmDiI5coxYqH3StoXF0M+yDRBA59uTuvO745J+ZvwQD7B8b3fcf0a6d0gjESy58khVQJLQ vG4gqYaTf+jZHaoh40wvGIGBtd791OQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-A_XBRnSRM6CSK002x83ONA-1; Thu, 03 Dec 2020 08:32:55 -0500 X-MC-Unique: A_XBRnSRM6CSK002x83ONA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACAC78B7CD9; Thu, 3 Dec 2020 13:32:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04AE37EA2F; Thu, 3 Dec 2020 13:32:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 05501180954D; Thu, 3 Dec 2020 13:32:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B3DVF3I011187 for ; Thu, 3 Dec 2020 08:31:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2F5055D6CF; Thu, 3 Dec 2020 13:31:15 +0000 (UTC) Received: from x2.localnet (unknown [10.10.115.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id 827965D6AC; Thu, 3 Dec 2020 13:31:11 +0000 (UTC) From: Steve Grubb To: Paul Moore Subject: Re: [PATCH v2] audit: report audit wait metric in audit status reply Date: Thu, 03 Dec 2020 08:31:10 -0500 Message-ID: <2565471.mvXUDI8C0e@x2> Organization: Red Hat In-Reply-To: References: <20200701213244.GA1817@linux-kernel-dev> <11647352.O9o76ZdvQC@x2> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wednesday, December 2, 2020 11:12:31 PM EST Paul Moore wrote: > On Wed, Dec 2, 2020 at 10:52 PM Steve Grubb wrote: > > Hello Paul, > > Steve. > > > On Thursday, July 2, 2020 4:42:13 PM EST Paul Moore wrote: > > > > #define AUDIT_FEATURE_BITMAP_BACKLOG_LIMIT 0x00000001 > > > > #define AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME 0x00000002 > > > > @@ -348,6 +349,7 @@ enum { > > > > #define AUDIT_FEATURE_BITMAP_SESSIONID_FILTER 0x00000010 > > > > #define AUDIT_FEATURE_BITMAP_LOST_RESET 0x00000020 > > > > #define AUDIT_FEATURE_BITMAP_FILTER_FS 0x00000040 > > > > +#define AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_SUM 0x00000080 > > > > > > In an effort not to exhaust the feature bitmap too quickly, I've been > > > restricting it to only those features that would cause breakage with > > > userspace. I haven't looked closely at Steve's userspace in quite a > > > while, but I'm guessing it can key off the structure size and doesn't > > > need this entry in the bitmap, right? Let me rephrase, if userspace > > > needs to key off anything, it *should* key off the structure size and > > > not a new flag in the bitmask > > > > > > Also, I'm assuming that older userspace doesn't blow-up if it sees the > > > larger structure size? That's even more important. > > > > We need this FEATURE_BITMAP to do anything in userspace. Max's instinct > > was right. Anything that changes the user space API needs to have a > > FEATURE_BITMAP so that user space can do the right thing. The lack of > > this is blocking acceptance of the pull request for the user space > > piece. > > I don't believe you need a new bitmap entry in this case, you should > be able to examine the size of the reply from the AUDIT_GET request > and make a determination from there. For the upstream kernel, this may be the case. But in the world where people backport patches, how do I know that the size is related to this patch and no other? -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit