From: Steve Grubb <sgrubb@redhat.com>
To: Linux-Audit Mailing List <linux-audit@redhat.com>,
Richard Guy Briggs <rgb@redhat.com>
Subject: Re: [PATCH v1] remove unused fn audit_add_dir and decl audit_rule_syscall_data
Date: Thu, 28 Oct 2021 17:13:53 -0400 [thread overview]
Message-ID: <2725023.mvXUDI8C0e@x2> (raw)
In-Reply-To: <20211028194839.3100859-1-rgb@redhat.com>
On Thursday, October 28, 2021 3:48:39 PM EDT Richard Guy Briggs wrote:
> The former has no activity since pre-1.7.4, no in-tree users and no
> manpage, so remove it. The latter is only used locally, remove prototype.
The purpose for this is lost in time. Applied.
Thanks,
-Steve
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> lib/libaudit.c | 5 -----
> lib/libaudit.h | 2 --
> 2 files changed, 7 deletions(-)
>
> diff --git a/lib/libaudit.c b/lib/libaudit.c
> index bf3c22bc7beb..54e276156ef0 100644
> --- a/lib/libaudit.c
> +++ b/lib/libaudit.c
> @@ -742,11 +742,6 @@ int audit_add_watch(struct audit_rule_data **rulep,
> const char *path) return audit_add_watch_dir(AUDIT_WATCH, rulep, path);
> }
>
> -int audit_add_dir(struct audit_rule_data **rulep, const char *path)
> -{
> - return audit_add_watch_dir(AUDIT_DIR, rulep, path);
> -}
> -
> int audit_add_watch_dir(int type, struct audit_rule_data **rulep,
> const char *path)
> {
> diff --git a/lib/libaudit.h b/lib/libaudit.h
> index 6bd1758eb9d3..4e532177aa11 100644
> --- a/lib/libaudit.h
> +++ b/lib/libaudit.h
> @@ -656,7 +656,6 @@ extern int audit_request_signal_info(int fd);
> /* AUDIT_WATCH */
> extern int audit_update_watch_perms(struct audit_rule_data *rule, int
> perms); extern int audit_add_watch(struct audit_rule_data **rulep, const
> char *path); -extern int audit_add_dir(struct audit_rule_data **rulep,
> const char *path); extern int audit_add_watch_dir(int type, struct
> audit_rule_data **rulep, const char *path);
> extern int audit_trim_subtrees(int fd);
> @@ -701,7 +700,6 @@ extern int audit_log_user_command(int audit_fd, int
> type, const char *command, extern struct audit_rule_data
> *audit_rule_create_data(void);
> /* Initializes an existing audit_rule_data struct */
> extern void audit_rule_init_data(struct audit_rule_data *rule);
> -extern int audit_rule_syscall_data(struct audit_rule_data *rule, int
> scall); extern int audit_rule_syscallbyname_data(struct audit_rule_data
> *rule, const char *scall);
> /* Note that the following function takes a **, where
> audit_rule_fieldpair()
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2021-10-28 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 19:48 [PATCH v1] remove unused fn audit_add_dir and decl audit_rule_syscall_data Richard Guy Briggs
2021-10-28 21:13 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2725023.mvXUDI8C0e@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).