From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C2DC433F5 for ; Thu, 28 Oct 2021 21:14:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19797610A4 for ; Thu, 28 Oct 2021 21:14:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19797610A4 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635455671; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+1SdXaASXzYpHZ0zTag52pf0V/cj8ooopo33NDFa6ok=; b=RCz+z03MdLKOYn0iSsKsgWT7JeRR/uYOGK1GAti9ints3VrumqyUVlwcV4Ipm0eM2ZW473 JVXEQ5NYyzOhXrQhsS60C1KT+5D3B3kjcE2EfhqhFg+f3Ub9EPtNx/FRq0XK6eebZgerEC DZ20ZiMHFxEEVEFEanJoQfa34qKTlO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585--iAb-goNPfeeNiiQRiaFng-1; Thu, 28 Oct 2021 17:14:27 -0400 X-MC-Unique: -iAb-goNPfeeNiiQRiaFng-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1BA403FAB; Thu, 28 Oct 2021 21:14:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718FB5BAE5; Thu, 28 Oct 2021 21:14:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 47B3E4A703; Thu, 28 Oct 2021 21:14:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19SLEKmW026859 for ; Thu, 28 Oct 2021 17:14:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2C98D18351; Thu, 28 Oct 2021 21:14:20 +0000 (UTC) Received: from x2.localnet (unknown [10.22.33.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA6DC5D9DE; Thu, 28 Oct 2021 21:13:53 +0000 (UTC) From: Steve Grubb To: Linux-Audit Mailing List , Richard Guy Briggs Subject: Re: [PATCH v1] remove unused fn audit_add_dir and decl audit_rule_syscall_data Date: Thu, 28 Oct 2021 17:13:53 -0400 Message-ID: <2725023.mvXUDI8C0e@x2> Organization: Red Hat In-Reply-To: <20211028194839.3100859-1-rgb@redhat.com> References: <20211028194839.3100859-1-rgb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thursday, October 28, 2021 3:48:39 PM EDT Richard Guy Briggs wrote: > The former has no activity since pre-1.7.4, no in-tree users and no > manpage, so remove it. The latter is only used locally, remove prototype. The purpose for this is lost in time. Applied. Thanks, -Steve > Signed-off-by: Richard Guy Briggs > --- > lib/libaudit.c | 5 ----- > lib/libaudit.h | 2 -- > 2 files changed, 7 deletions(-) > > diff --git a/lib/libaudit.c b/lib/libaudit.c > index bf3c22bc7beb..54e276156ef0 100644 > --- a/lib/libaudit.c > +++ b/lib/libaudit.c > @@ -742,11 +742,6 @@ int audit_add_watch(struct audit_rule_data **rulep, > const char *path) return audit_add_watch_dir(AUDIT_WATCH, rulep, path); > } > > -int audit_add_dir(struct audit_rule_data **rulep, const char *path) > -{ > - return audit_add_watch_dir(AUDIT_DIR, rulep, path); > -} > - > int audit_add_watch_dir(int type, struct audit_rule_data **rulep, > const char *path) > { > diff --git a/lib/libaudit.h b/lib/libaudit.h > index 6bd1758eb9d3..4e532177aa11 100644 > --- a/lib/libaudit.h > +++ b/lib/libaudit.h > @@ -656,7 +656,6 @@ extern int audit_request_signal_info(int fd); > /* AUDIT_WATCH */ > extern int audit_update_watch_perms(struct audit_rule_data *rule, int > perms); extern int audit_add_watch(struct audit_rule_data **rulep, const > char *path); -extern int audit_add_dir(struct audit_rule_data **rulep, > const char *path); extern int audit_add_watch_dir(int type, struct > audit_rule_data **rulep, const char *path); > extern int audit_trim_subtrees(int fd); > @@ -701,7 +700,6 @@ extern int audit_log_user_command(int audit_fd, int > type, const char *command, extern struct audit_rule_data > *audit_rule_create_data(void); > /* Initializes an existing audit_rule_data struct */ > extern void audit_rule_init_data(struct audit_rule_data *rule); > -extern int audit_rule_syscall_data(struct audit_rule_data *rule, int > scall); extern int audit_rule_syscallbyname_data(struct audit_rule_data > *rule, const char *scall); > /* Note that the following function takes a **, where > audit_rule_fieldpair() -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit