From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: don't attempt to lookup PIDs when changing PID filtering audit rules
Date: Mon, 15 Dec 2014 14:14:25 -0500 [thread overview]
Message-ID: <2949504.5MHzOgfemX@sifl> (raw)
In-Reply-To: <20141215185057.GA6439@madcap2.tricolour.ca>
On Monday, December 15, 2014 01:50:57 PM Richard Guy Briggs wrote:
> I've still got outstanding patches to store PIDs as struct pid rather
> than pid_t, so this was part of the motivation to start that in this
> code.
Funny you mention this, while I was hunting for the root cause of the problem,
I had a patch which did just that, adding a pid struct to the audit_field
struct. Eventually we will have to go that route as (sadly) a PID is no
longer sufficient to identify a process on the system, you need PID+ns. We'll
still have the find_pid() problem then, but there are ways around that by
being smarter about how we add/delete/store filtering rules.
I opted for the patch I posted here because as you point out we really only
work in the init namespace and it didn't muddle the bugfix with new
functionality.
--
paul moore
security and virtualization @ redhat
next prev parent reply other threads:[~2014-12-15 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:14 [PATCH] audit: don't attempt to lookup PIDs when changing PID filtering audit rules Paul Moore
2014-12-15 17:29 ` Eric Paris
2014-12-15 18:50 ` Richard Guy Briggs
2014-12-15 18:51 ` Eric Paris
2014-12-15 19:15 ` Paul Moore
2014-12-15 19:33 ` Richard Guy Briggs
2014-12-15 19:58 ` Paul Moore
2014-12-15 19:14 ` Paul Moore [this message]
2014-12-15 19:03 ` Paul Moore
2014-12-15 21:14 ` Steve Grubb
2014-12-15 21:24 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2949504.5MHzOgfemX@sifl \
--to=pmoore@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox