From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: Embedded libev library
Date: Sat, 09 Feb 2013 11:23:12 -0500
Message-ID: <2975310.5k4NdiXIv7@x2>
References: <20130209161352.677c9c42@fornost.bigon.be>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <20130209161352.677c9c42@fornost.bigon.be>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Saturday, February 09, 2013 04:13:52 PM Laurent Bigonville wrote:
> I've a question about the embedded version of libev. Is there any
> particular reason you are shipping it? 

Yes, it has bug fixes in it. If you have ever dealt with upstream for that 
project, then you know how difficult it can be to report bugs.

https://fedorahosted.org/audit/changeset/679
https://fedorahosted.org/audit/changeset/698

I know of one more bug that needs fixing in that library.

>Or is it only for convenience?

Nope. This one in particular breaks the build for audit:
https://fedorahosted.org/audit/changeset/679/trunk/src/libev/ev.h


> The Debian archive is containing already containing libev (4.11) and
> it's usually considered bad practice to embed libraries that are
> already contained in the archive.
> 
> Would you accept a patch to allow building audit against the system
> libev library?

Sure. But I want it to default to using the embedded one so there are no 
regressions out of the box.

Thanks,
-Steve