From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
sgrubb@redhat.com, eparis@redhat.com
Subject: Re: [PATCH V5] audit: use macros for unset inode and device values
Date: Thu, 06 Aug 2015 14:37:43 -0400 [thread overview]
Message-ID: <3232354.zp6VWdiO1X@sifl> (raw)
In-Reply-To: <20150806034034.GA18741@madcap2.tricolour.ca>
On Wednesday, August 05, 2015 11:40:34 PM Richard Guy Briggs wrote:
> On 15/08/05, Paul Moore wrote:
> > I suspect it was lost in the noise when I mentioned it on v4, but how
> > about changing AUDIT_DEV_UNSET to "(dev_t)-1"?
>
> I saw your comment only after resubmitting. I'm fine either way. If it
> is needed for uapi later it can be changed then. Is it easy to change
> in your workflow, or should I resubmit? I know you routinely change the
> patch description, but could not remember if you have actually changed
> the patch itself...
With the exception of trivial merge conflicts, in general I like to avoid
changing the body of the patches when I apply them; there are always going to
be exceptions, but when possible I try to avoid it. I consider tweaking the
patch subject lines pretty trivial, especially in the last case where the
subject line had become wrong/invalid due to changes in the patch itself.
--
paul moore
security @ redhat
next prev parent reply other threads:[~2015-08-06 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 20:19 [PATCH V5] audit: use macros for unset inode and device values Richard Guy Briggs
2015-08-05 21:53 ` Paul Moore
2015-08-06 3:40 ` Richard Guy Briggs
2015-08-06 18:37 ` Paul Moore [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-06 3:48 Richard Guy Briggs
2015-08-06 18:49 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3232354.zp6VWdiO1X@sifl \
--to=pmoore@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).