Re: [RFC][PATCH] audit: log join and part events to the read-only multicast log socket

Paul Moore
2014-10-07T22:06:51Z

On Tuesday, October 07, 2014 03:39:51 PM Richard Guy Briggs wrote:
> I also thought of moving audit_log_task() from auditsc.c to audit.c
> and using that. For that matter, both audit_log_task() and
> audit_log_task_info() could use audit_log_session_info(), but they are
> in slightly different order of keywords which will upset sgrubb's
> parser.

A bit of an aside from the patch, but in my opinion the parser should be made
a bit more robust so that it can handle fields in any particular order. I
agree that having fields in a "canonical ordering" is helpful, both for tools
and people, but the tools shouldn't require it in my opinion.

Steve, why exactly can't the userspace parser handle fields in any order? How
difficult would it be to fix?

--
paul moore
security and virtualization @ redhat