linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: Python auparse bindings memory leak
Date: Thu, 21 Apr 2016 15:16:50 -0400	[thread overview]
Message-ID: <3541870.8J2ZBOWMtA@x2> (raw)
In-Reply-To: <CAPYiZnmdMx2GhdUcPo8x8jzUu_SrPzxgKeUFkK8Q-j_GDQ+ybw@mail.gmail.com>

Hello,

On Thursday, April 14, 2016 02:37:19 PM Santosh Ananthakrishnan wrote:
> The get_timestamp function in the auparse extension module seems to have an
> extra Py_INCREF. There's already a #FIXME at the line:
> https://fedorahosted.org/audit/browser/tags/audit-2.5.1/bindings/python/aupa
> rse_python.c#L1090 .
> 
> Has this been investigated before?

I was able to confirm this is leaking memory.

> Rebuilding the package with that increment removed resolved our memory usage
> issues, so I'm hoping this doesn't silently break something.

That appears to be the fix. Thanks for reporting the issue.

-Steve

      reply	other threads:[~2016-04-21 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 21:37 Python auparse bindings memory leak Santosh Ananthakrishnan
2016-04-21 19:16 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3541870.8J2ZBOWMtA@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).