From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: Python auparse bindings memory leak
Date: Thu, 21 Apr 2016 15:16:50 -0400
Message-ID: <3541870.8J2ZBOWMtA@x2>
References: <CAPYiZnmdMx2GhdUcPo8x8jzUu_SrPzxgKeUFkK8Q-j_GDQ+ybw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <CAPYiZnmdMx2GhdUcPo8x8jzUu_SrPzxgKeUFkK8Q-j_GDQ+ybw@mail.gmail.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

Hello,

On Thursday, April 14, 2016 02:37:19 PM Santosh Ananthakrishnan wrote:
> The get_timestamp function in the auparse extension module seems to have an
> extra Py_INCREF. There's already a #FIXME at the line:
> https://fedorahosted.org/audit/browser/tags/audit-2.5.1/bindings/python/aupa
> rse_python.c#L1090 .
> 
> Has this been investigated before?

I was able to confirm this is leaking memory.

> Rebuilding the package with that increment removed resolved our memory usage
> issues, so I'm hoping this doesn't silently break something.

That appears to be the fix. Thanks for reporting the issue.

-Steve