Python auparse bindings memory leak

Python auparse bindings memory leak

[Santosh Ananthakrishnan]

[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]

Hi list

The get_timestamp function in the auparse extension module seems to have an
extra Py_INCREF. There's already a #FIXME at the line:
https://fedorahosted.org/audit/browser/tags/audit-2.5.1/bindings/python/auparse_python.c#L1090
.

Has this been investigated before? Rebuilding the package with that
increment removed resolved our memory usage issues, so I'm hoping this
doesn't silently break something.

-Santosh

[-- Attachment #1.2: Type: text/html, Size: 651 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: Python auparse bindings memory leak

[Steve Grubb]

Hello,

On Thursday, April 14, 2016 02:37:19 PM Santosh Ananthakrishnan wrote:
> The get_timestamp function in the auparse extension module seems to have an
> extra Py_INCREF. There's already a #FIXME at the line:
> https://fedorahosted.org/audit/browser/tags/audit-2.5.1/bindings/python/aupa
> rse_python.c#L1090 .
> 
> Has this been investigated before?

I was able to confirm this is leaking memory.

> Rebuilding the package with that increment removed resolved our memory usage
> issues, so I'm hoping this doesn't silently break something.

That appears to be the fix. Thanks for reporting the issue.

-Steve