From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCE6C433E0 for ; Sun, 21 Jun 2020 18:38:58 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D9BF25227 for ; Sun, 21 Jun 2020 18:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RDte2dLq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D9BF25227 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592764737; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L3z2O2Isn7b0+vAPhFazENk/jkrYEMB+RljxYTlCIL4=; b=RDte2dLqSBB4fhJGW5mMKdNGS4QqnPkc8Wth+BQCRS3lasmUtweDeikKRdSuikX+rtL6Hb m1gmSKDiWNgUecB7AJ4n4EHLwqeJe0x/piIFAKwR5fR9WCOfIPGn1F02Ofixuhus4OGLLp AvT8p6A7fjTP4S+RoqiC4gARsNyV9DM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-224-iruUg2z9MU2G1ZMzvltGuQ-1; Sun, 21 Jun 2020 14:38:54 -0400 X-MC-Unique: iruUg2z9MU2G1ZMzvltGuQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46ABC1883604; Sun, 21 Jun 2020 18:38:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FE3F71671; Sun, 21 Jun 2020 18:38:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B2889833B1; Sun, 21 Jun 2020 18:38:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05LIchna005200 for ; Sun, 21 Jun 2020 14:38:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4107460C87; Sun, 21 Jun 2020 18:38:43 +0000 (UTC) Received: from x2.localnet (ovpn-112-97.phx2.redhat.com [10.3.112.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id F317960BF1; Sun, 21 Jun 2020 18:38:40 +0000 (UTC) From: Steve Grubb To: linux-audit@redhat.com Subject: Re: Error handling of auditctl -w Date: Sun, 21 Jun 2020 14:38:39 -0400 Message-ID: <3816311.bfVM1qvdfx@x2> Organization: Red Hat In-Reply-To: <1MXp9Y-1jOF6E24IW-00Y8HI@mail.gmx.com> References: <1MXp9Y-1jOF6E24IW-00Y8HI@mail.gmx.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: linux-audit@redhat.com Cc: Stefan Tauner X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, On Tuesday, June 16, 2020 4:00:17 PM EDT Stefan Tauner wrote: > I was wondering why my auditctl executions do not print any errors but > apparently didn't do anything. After checking the return value (which > was 255) I looked at the code and noticed that audit_setup_perms() and > audit_update_watch_perms() have virtually no user-visible error reporting. Git commit 4a2b9fd should fix this. Thanks for reporting it! -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit