From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] filterkey: add errormsg reporting
Date: Mon, 12 Jun 2017 20:02:25 -0400
Message-ID: <4084249.yv8OCQJMUB@x2>
References: <1491302321-1048-1-git-send-email-rgb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1491302321-1048-1-git-send-email-rgb@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Richard Guy Briggs <rgb@redhat.com>, Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Tuesday, April 4, 2017 6:38:41 AM EDT Richard Guy Briggs wrote:
> Call errormsg after processing filterkey to speed up debugging.

Applied. Thanks!

-Steve

> See: https://github.com/linux-audit/audit-userspace/issues/13
> 
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  src/auditctl.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/auditctl.c b/src/auditctl.c
> index e112b16..04765f4 100644
> --- a/src/auditctl.c
> +++ b/src/auditctl.c
> @@ -1091,8 +1091,10 @@ process_keys:
>  	} else {
>  		/* Add this to the rule */
>  		int ret = audit_rule_fieldpair_data(&rule_new, cmd, flags);
> -		if (ret < 0)
> +		if (ret != 0) {
> +			audit_number_to_errmsg(ret, cmd);
>  			retval = -1;
> +		}
>  		free(cmd);
>  	}
>      }