From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Cc: rgb@redhat.com, William Roberts <wroberts@tresys.com>
Subject: Re: [PATCH] audit: Add cmdline to taskinfo output
Date: Tue, 29 Oct 2013 11:14:35 -0400 [thread overview]
Message-ID: <41913182.01FMG6Aupv@x2> (raw)
In-Reply-To: <1383004238-10998-1-git-send-email-wroberts@tresys.com>
On Monday, October 28, 2013 04:50:38 PM William Roberts wrote:
> On some devices, the cmdline and task info vary. For instance, on
> Android, the cmdline is set to the package name, and the task info
> is the name of the VM, which is not very helpful.
>
> The additional cmdline output only runs if the audit feature
> AUDIT_FEATURE_CMDLINE_OUTPUT is set high at runtime.
I don't exactly like this. The audit event records are very normalized. When
you have a specific kind of record, you can count on always having the certain
fields even if its value is (NULL). So, having fields swinging in and out by
configuration is not something I'd like to see start.
Can you show me an event that has the problem and what it looks like when its
fixed by this patch?
Thanks,
-Steve
next prev parent reply other threads:[~2013-10-29 15:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 23:50 [PATCH] audit: Add cmdline to taskinfo output William Roberts
2013-10-29 15:14 ` Steve Grubb [this message]
2013-10-29 17:44 ` William Roberts
2013-10-29 17:55 ` William Roberts
2013-10-29 19:01 ` Steve Grubb
2013-10-29 19:12 ` William Roberts
2013-10-29 19:55 ` Steve Grubb
2013-10-29 20:25 ` William Roberts
2013-10-29 23:24 ` William Roberts
2013-10-30 0:43 ` William Roberts
2013-10-30 19:42 ` Steve Grubb
2013-10-30 20:18 ` William Roberts
2013-10-30 21:20 ` Eric Paris
2013-10-30 21:52 ` William Roberts
2013-10-31 14:36 ` Steve Grubb
2013-10-31 15:24 ` William Roberts
2013-10-31 15:28 ` Richard Guy Briggs
2013-10-31 15:33 ` William Roberts
2013-10-31 15:46 ` Richard Guy Briggs
2013-10-31 15:51 ` William Roberts
2013-10-31 15:52 ` William Roberts
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 23:47 William Roberts
2013-10-23 20:40 William Roberts
2013-10-24 19:10 ` Richard Guy Briggs
2013-10-28 13:48 ` William Roberts
2013-10-28 15:10 ` Richard Guy Briggs
2013-10-28 16:30 ` William Roberts
2013-10-28 19:02 ` William Roberts
2013-10-28 21:52 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41913182.01FMG6Aupv@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
--cc=wroberts@tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox