From: Steve Grubb <sgrubb@redhat.com>
To: "Mor, Omri" <omrimor2@illinois.edu>
Cc: "linux-audit@redhat.com" <linux-audit@redhat.com>
Subject: Re: audit-userspace: auparse/lru.c sanity_check_queue() compile error with DEBUG
Date: Wed, 20 Dec 2017 16:19:42 -0500 [thread overview]
Message-ID: <4549450.qjQlotygAB@x2> (raw)
In-Reply-To: <BBDBE9E7-6AC1-479D-B18C-FDD8D8D126A0@illinois.edu>
[-- Attachment #1.1: Type: text/plain, Size: 681 bytes --]
On Tuesday, December 19, 2017 2:49:08 PM EST Mor, Omri wrote:
> >> sanity_check_queue() attempts to call msg(), which as far as I can tell
> >> isn’t defined. It appears that this should be syslog() or audit_msg()
> >> instead.
> >> This causes compilation failure when DEBUG is defined.
> >
> > Thanks for reporting this. The function name is now fixed in git.
>
> On second look, I think it’s supposed to be syslog(), not audit_msg().
> The rest of the code in auparse/lru.c calls syslog(),
Yes, I see that now. Normally syslog is wrapped so that messages can be switched
between stderr and syslog depending on the needs. Its fixed again in git.
-Steve
[-- Attachment #1.2: Type: text/html, Size: 3218 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2017-12-20 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 1:19 audit-userspace: auparse/lru.c sanity_check_queue() compile error with DEBUG Mor, Omri
2017-12-18 17:34 ` Steve Grubb
2017-12-19 19:49 ` Mor, Omri
2017-12-20 21:19 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4549450.qjQlotygAB@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=omrimor2@illinois.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox