From mboxrd@z Thu Jan  1 00:00:00 1970
From: Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH][RFC] V1 Remove SELinux dependencies from linux-audit via LSM
Date: Fri, 3 Aug 2007 09:33:19 -0700 (PDT)
Message-ID: <457110.86749.qm@web36606.mail.mud.yahoo.com>
References: <922084.93856.qm@web36605.mail.mud.yahoo.com>
Reply-To: casey@schaufler-ca.com
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Return-path: <linux-security-module-owner@vger.kernel.org>
In-Reply-To: <922084.93856.qm@web36605.mail.mud.yahoo.com>
Sender: linux-security-module-owner@vger.kernel.org
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: LSM List <linux-security-module@vger.kernel.org>, SELinux List <selinux@tycho.nsa.gov>, Audit List <linux-audit@redhat.com>
List-Id: linux-audit@redhat.com


--- Casey Schaufler <casey@schaufler-ca.com> wrote:

> > > diff -uprN -X linux-2.6.22-base/Documentation/dontdiff
> > > linux-2.6.22-base/include/linux/security.h
> > > linux-2.6.22-audit/include/linux/security.h
> > > --- linux-2.6.22-base/include/linux/security.h	2007-07-08
> > 16:32:17.000000000
> > > -0700
> > > +++ linux-2.6.22-audit/include/linux/security.h	2007-08-01
> > 20:14:18.000000000
> > > -0700
> > > @@ -35,6 +35,8 @@
> > >  #include <net/flow.h>
> > >  
> > >  struct ctl_table;
> > > +struct audit_krule;
> > > +struct selinux_audit_rule;
> > 
> > selinux_audit_rule in LSM interface?
> 
> The structure needs a new name. Any objections to audit_rule_lsm?
> I'd suggest security_audit_rule, but that doesn't say anything about
> where to look to see how it gets used.

Actually, it's worse than that because an selinux_audit_rule really
is SELinux specific. Any problem with making the security_audit_rule
interfaces use a void * ? The audit code appears to be accomodating.



Casey Schaufler
casey@schaufler-ca.com