From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98167C433E0 for ; Tue, 2 Mar 2021 15:11:11 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1021864EF0 for ; Tue, 2 Mar 2021 15:11:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1021864EF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614697869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fqn4GaTbyndO3vh8+3Z3JsT9jt9Xaqrkvq2ZSo0ryfA=; b=G7Nvq8fV7iTiJbi03qDszlFwgGF9lEs4mqAYfZTgTYyrDIbb/R/v0Q/wIkF66cZWxRgukz +Y3yczPz0DpfIkx/cCb942F6TfiJDG3ADPuG0IOLhyuLBaejOLtTbslLCyV53qb/dPpMYO oinWxyP5JrGasHJ4Nb8bzGKz4/9gY/g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-YFtcnkcTMk6IdF1O1AqpAQ-1; Tue, 02 Mar 2021 10:11:08 -0500 X-MC-Unique: YFtcnkcTMk6IdF1O1AqpAQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1811D80196C; Tue, 2 Mar 2021 15:11:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7259F5C1BB; Tue, 2 Mar 2021 15:11:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 35D4F18095C9; Tue, 2 Mar 2021 15:10:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 122FAvc7016852 for ; Tue, 2 Mar 2021 10:10:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id 52A6A57; Tue, 2 Mar 2021 15:10:57 +0000 (UTC) Received: from x2.localnet (ovpn-116-197.rdu2.redhat.com [10.10.116.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04CBC5C1BB; Tue, 2 Mar 2021 15:10:56 +0000 (UTC) From: Steve Grubb To: Paul Moore Subject: Re: open_by_handle_at and CVE-2020-35501 Date: Tue, 02 Mar 2021 10:10:55 -0500 Message-ID: <4648666.31r3eYUQgx@x2> Organization: Red Hat In-Reply-To: References: <7230785.EvYhyI6sBW@x2> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello Paul, On Thursday, February 25, 2021 5:28:11 PM EST Paul Moore wrote: > On Thu, Feb 25, 2021 at 5:15 PM Steve Grubb wrote: > > Hello, > > > > There was an announcement on the oss-security mail list a week ago: > > > > https://seclists.org/oss-sec/2021/q1/155 > > > > regarding auditing of the open_by_handle_at system call ... > > The *at() syscalls are a known issue with respect to audit; we have a > few open GH issues related to the topic, the oldest appears to be the > one below: > > * https://github.com/linux-audit/audit-kernel/issues/9 Yes, that is true. But this is a bit different because at least those *at functions get triggered by -F perm=xrwa. Should one or both of the syscalls be added to the filter? And name_to_handle_at() appears to be yet another kernel system call who's arg4 has something that is security relevant. So, it looks like there are probably 3 work items: 1) add syscall(s) to the perm filter, 2) add an auxiliary record to grab the arg4 flags variable, 3) add to the list of functions that have *at path resolution issues. -Steve > > ... In any event, they are asking what upstream audit is going to do > > about this? > I recognize it sounds a bit trite here, but "patches are always > welcome". Basically someone needs to have the time and motivation to > look into this and put forth some patches that we can discuss and > iterate over. The problem is that historically audit has attracted > very few kernel developers outside the occasional development push by > a distro preparing a OS release for a certification effort. I was > just lamenting this fact on a private mail thread with some other > kernel developers a couple of weeks ago ... -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit