From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B40C433EF for ; Sat, 2 Oct 2021 13:16:26 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 043A761B1E for ; Sat, 2 Oct 2021 13:16:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 043A761B1E Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633180584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/lID1NpNBtS8O0zbZm4N/Oh5k0TI9+oGRqrtvgyqMZo=; b=CmTL9QbYvuvINDdQzbMqrzZr89UykvEPJPghA0l6cfcRX6AGLbxw9MkTZ07IDT+SVdPW+j MjW9fhXM/Rvb8GKO0WIC8J7noSR+14CK7OVxahkM26cgMLfbxWe2qSZXGfzDZWoggAyCd1 BtllcvaJqTL71oHGUDtTXt6SCBdVvX4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-sjsw3SSMO8u3RsDiZsVtRw-1; Sat, 02 Oct 2021 09:16:23 -0400 X-MC-Unique: sjsw3SSMO8u3RsDiZsVtRw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD5CE18125C0; Sat, 2 Oct 2021 13:16:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F20315DA61; Sat, 2 Oct 2021 13:16:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B3B81801241; Sat, 2 Oct 2021 13:16:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 192DGFH8026382 for ; Sat, 2 Oct 2021 09:16:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 772505C1CF; Sat, 2 Oct 2021 13:16:15 +0000 (UTC) Received: from x2.localnet (unknown [10.22.32.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EE8C5C3DF; Sat, 2 Oct 2021 13:16:03 +0000 (UTC) From: Steve Grubb To: Richard Guy Briggs Subject: Re: [RFC PATCH v2 0/9] Add LSM access controls and auditing to io_uring Date: Sat, 02 Oct 2021 09:16:01 -0400 Message-ID: <4721749.31r3eYUQgx@x2> Organization: Red Hat In-Reply-To: <20210910005858.GL490529@madcap2.tricolour.ca> References: <20210824205724.GB490529@madcap2.tricolour.ca> <20210910005858.GL490529@madcap2.tricolour.ca> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, Since this is a chat to discuss merging the user space piece, I trimmed the recipients down to the audit community. On Thursday, September 9, 2021 8:58:58 PM EDT Richard Guy Briggs wrote: > > I spent some time this morning/afternoon playing with the io_uring > > audit filtering capability and with your audit userspace > > ghau-iouring-filtering.v1.0 branch it appears to work correctly. Yes, > > the userspace tooling isn't quite 100% yet (e.g. `auditctl -l` doesn't > > map the io_uring ops correctly), but I know you mentioned you have a > > number of fixes/improvements still as a work-in-progress there so I'm > > not too concerned. The important part is that the kernel pieces look > > to be working correctly. > > Ok, I have squashed and pushed the audit userspace support for iouring: > > https://github.com/rgbriggs/audit-userspace/commit/e8bd8d2ea8adcaa758024cb > 9b8fa93895ae35eea > https://github.com/linux-audit/audit-userspace/compare/master...rgbriggs:g > hak-iouring-filtering.v2.1 There are test rpms for f35 here: > http://people.redhat.com/~rbriggs/ghak-iouring/git-e8bd8d2-fc35/ > > userspace v2 changelog: > - check for watch before adding perm > - update manpage to include filesystem filter > - update support for the uring filter list: doc, -U op, op names > - add support for the AUDIT_URINGOP record type > - add uringop support to ausearch > - add uringop support to aureport > - lots of bug fixes > > "auditctl -a uring,always -S ..." will now throw an error and require > "-U" instead. OK, now that the bug fix release is out of the way, let's start merging this into user space. I think we should start with the code that let's auditd write the record correctly and then the auditctl piece that inserts the rule into the kernel. Those should be easy to merge. I see one section of code that mirrors all of the operations in ioring.h. I thought that Paul only wanted to audit some of the operations and not all of them. Did that change? Are we really going to allow auditing reads on ioring? I would also prefer that we use the ioring enums rather than maintain a number mapping of all of the ioring enums text representation. But let's start with this piece first. Send just the auditctl/auditd pieces and let's start merging that. We'll get to the other pieces after that. Thanks, -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit