From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miloslav Trmac <mitr@redhat.com>
Subject: Re: [PATCH] Audit: EINTR instead of kernel private return codes in
 audit records
Date: Wed, 14 Nov 2007 22:13:39 +0100
Message-ID: <473B6503.3090804@redhat.com>
References: <1195071728.2924.40.camel@localhost.localdomain>
	<200711141530.56256.sgrubb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <200711141530.56256.sgrubb@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Steve Grubb <sgrubb@redhat.com>
Cc: linux-audit@redhat.com, pmoore@hp.com
List-Id: linux-audit@redhat.com

Steve Grubb napsal(a):
> On Wednesday 14 November 2007 15:22:08 Eric Paris wrote:
>> +       if (unlikely((return_code == -ERESTART_RESTARTBLOCK) ||
>> +                    (return_code == -ERESTARTNOHAND) ||
>> +                    (return_code == -ERESTARTSYS) ||
>> +                    (return_code == -ERESTARTNOINTR)))
> 
> Would it be more efficient to say:
> 
> if (unlikely(return_code <= -ERESTARTSYS && 
>                return_code >= -ERESTART_RESTARTBLOCK))
> 
> That gets it down to 2 compares and 1 logical op.
gcc performs this transformation automatically.
	Mirek