From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Dennis Subject: Re: [PATCH] Fix acct quoting in audit_log_acct_message()) Date: Tue, 04 Mar 2008 15:41:58 -0500 Message-ID: <47CDB416.7070303@redhat.com> References: <47CCC6F0.1090005@redhat.com> <47CD65A3.8020204@redhat.com> <1204654248.12783.32.camel@vespa.frost.loc> <200803041356.19571.sgrubb@redhat.com> <1204658129.3216.118.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1204658129.3216.118.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Eric Paris Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com Eric Paris wrote: > But I admit, the parser would have to know that key is a string to > change it back. Adding two bytes to each string field (beginning and ending delimiters) is too big a burden? Instead we have to rely on difficult to manage tables to tell the parser it's a string? The 2 byte penalty might have had weight in 1970, but not in 2007. If we're really arguing over how many bytes a record consumes then we should switch to a binary protocol instead of text. Oh and by the way, in a binary protocol you would likely prefix string data with a length field, so you're going to end up using a couple of bytes anyway. -- John Dennis