From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Dennis <jdennis@redhat.com>
Subject: Re: [PATCH] Fix acct quoting in audit_log_acct_message())
Date: Tue, 04 Mar 2008 17:32:38 -0500
Message-ID: <47CDCE06.3070705@redhat.com>
References: <47CCC6F0.1090005@redhat.com>	<1204663403.3216.126.camel@localhost.localdomain>	<47CDBD3D.7030101@redhat.com>
	<200803041638.03430.sgrubb@redhat.com>	<1204667720.3216.161.camel@localhost.localdomain>
	<1204668183.3216.165.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1204668183.3216.165.camel@localhost.localdomain>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

Eric Paris wrote:
> it needs to stay an untrusted string, but its name, well yeah, that
> doesn't tell us a whole lot, does it?

It's the untrusted string code which is the primary culprit. If we fixed 
audit so that *all* strings written by audit are formatted by exactly 
one string formatting routine and that routine is sane then 99.99% of 
the problems would go away. That was the thrust of my original email and 
what I was most concerned about. Perhaps unfortunately the email 
included some optional suggestions which is what some folks latched onto 
obscuring the real issue.
-- 
John Dennis <jdennis@redhat.com>