From: Peng Haitao <penght@cn.fujitsu.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: audit-list <linux-audit@redhat.com>
Subject: [PATCH] Fix a bug of parsing "exe=" in function parse_user()
Date: Thu, 28 Aug 2008 18:41:24 +0800 [thread overview]
Message-ID: <48B680D4.7030006@cn.fujitsu.com> (raw)
Hello steve,
The value of "exe=" which is not in double quotation, cannot be right gotten.
For example:
# echo "type=USER_ROLE_CHANGE msg=audit(1219940034.985:363068): user pid=24741 uid=0 auid=0 subj=root:system_r:semanage_t:s0-s0:c0.c1023 msg='op=delete SELinux user mapping acct="sltester" old-seuser=? old-role=? old-range=? new-seuser=? new-role=? new-range=? exe=/usr/sbin/semanage (hostname=?, addr=?, terminal=? res=failed)'" | ausearch -x "/usr/sbin/semanage"
<no matches>
Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
src/ausearch-parse.c | 22 ++++++++++++++++++++--
1 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/src/ausearch-parse.c b/src/ausearch-parse.c
index b80b984..1bc598f 100644
--- a/src/ausearch-parse.c
+++ b/src/ausearch-parse.c
@@ -871,8 +871,26 @@ static int parse_user(const lnode *n, search_items *s)
*term = 0;
s->exe = strdup(str);
*term = '"';
- } else
- s->exe = unescape(str);
+ } else {
+ char *end = str;
+ int legacy = 0;
+
+ while (*end != ' ') {
+ if (!isxdigit(*end)) {
+ legacy = 1;
+ }
+ end++;
+ }
+ term = end;
+ if (!legacy)
+ s->exe = unescape(str);
+ else {
+ saved = *term;
+ *term = 0;
+ s->exe = strdup(str);
+ *term = saved;
+ }
+ }
}
}
--
1.5.3
--
Regards
Peng Haitao
next reply other threads:[~2008-08-28 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 10:41 Peng Haitao [this message]
2008-08-28 19:38 ` [PATCH] Fix a bug of parsing "exe=" in function parse_user() Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B680D4.7030006@cn.fujitsu.com \
--to=penght@cn.fujitsu.com \
--cc=linux-audit@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox