From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew G. Morgan" Subject: Re: [PATCH 1/4] CAPABILITIES: add cpu endian vfs caps structure Date: Mon, 20 Oct 2008 22:50:25 -0700 Message-ID: <48FD6DA1.5030402@kernel.org> References: <20081020222538.3895.50175.stgit@paris.rdu.redhat.com> <20081020222602.3895.77302.stgit@paris.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081020222602.3895.77302.stgit@paris.rdu.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Eric Paris Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com, viro@zeniv.linux.org.ok, sgrubb@redhat.com, serue@us.ibm.com List-Id: linux-audit@redhat.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Eric Paris wrote: > This patch add a generic cpu endian caps structure and enternally available > functions which retrieve fcaps information from disk. This information is > necessary so fcaps information can be collected and recorded by the audit > system. > [...] > CAP_FOR_EACH_U32(i) { > - __u32 value_cpu; > - > - if (i >= tocopy) { > - /* > - * Legacy capability sets have no upper bits > - */ > - bprm->cap_post_exec_permitted.cap[i] = 0; > + if (i > tocopy) { Shouldn't the above still be (i >= tocopy) ? Cheers Andrew -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFI/W2e+bHCR3gb8jsRAtDBAJ94XoCVXRDDycns4KEmLLBlYODiqACfUD7W wx996Hso7mGH9lcc8Eiq89k= =gx3P -----END PGP SIGNATURE-----