From mboxrd@z Thu Jan  1 00:00:00 1970
From: Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [Fwd: [PATCH][RFC] SMACK : add  logging support V1]
Date: Wed, 01 Apr 2009 15:21:42 -0700
Message-ID: <49D3E8F6.8090706@schaufler-ca.com>
References: <49B3AB1A.8040201@numericable.fr>	
	<49CDB485.5010809@schaufler-ca.com>	
	<1238422822.16684.74.camel@localhost.localdomain>	
	<49D10FC5.4060504@numericable.fr>	
	<1238441488.18717.54.camel@localhost.localdomain>	
	<49D28EAC.1040604@numericable.fr>
	<1238610138.14615.7.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32])
	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n31MMHdi001184
	for <linux-audit@redhat.com>; Wed, 1 Apr 2009 18:22:17 -0400
Received: from smtp110.prem.mail.sp1.yahoo.com
	(smtp110.prem.mail.sp1.yahoo.com [98.136.44.55])
	by mx3.redhat.com (8.13.8/8.13.8) with SMTP id n31MM0sc016300
	for <linux-audit@redhat.com>; Wed, 1 Apr 2009 18:22:00 -0400
In-Reply-To: <1238610138.14615.7.camel@localhost.localdomain>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com, jmorris@namei.org, Etienne Basset <etienne.basset@numericable.fr>
List-Id: linux-audit@redhat.com

Eric Paris wrote:
>> ...
>>
>> or using audit_log_untrustedstring  and live with the fact that Labels with '"' will be 
>> printed in hex (i dont expect '"' to be frequently used in labels.)
>>     
>
> Since it can contain a " you may not use %s.  Just go with
> audit_log_untrustedstring and hope people don't use a "
>   

I am willing to declare that ' and " may not be used in labels.
I've already done so with "/" to accommodate anyone who wants to
use a label in a path name. I've never allowed whitespace.

>   
>>> Can I suggest if you write userspace tools to do anything with these
>>> audit records that you use libauparse?  So if we do make changes, SMACK
>>> tools keep working (this is the main problem with changing how SELinux
>>> uses audit, the userspace tools don't use libauparse so we can't make
>>> changes in just the kernel+library...)
>>>
>>>       
>> i can have a look, but my first need is /var/log/messages being pretty obvious to read
>>     
>
> The changes to string encoding and we want to do would actually make
> records more human readable, so if that's your concern we are good.
> But, if you ever make tools that parse the raw audit.log rather than
> using libauparse it possible (likely?) they break someday down the line.
>
> Don't forget these are going to show up in /var/log/audit/audit.log if
> you have auditd running.  They'll show up in dmesg/syslog if not.
>
> Thanks for trying to share code between LSMs!
>
> -Eric
>
>
>