From mboxrd@z Thu Jan 1 00:00:00 1970 From: Etienne Basset Subject: Re: [PATCH 0/2] security/smack implement logging V2 Date: Mon, 06 Apr 2009 18:49:59 +0200 Message-ID: <49DA32B7.8080004@numericable.fr> References: <49D86FFA.1010507@numericable.fr> <1239032066.4009.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1239032066.4009.5.camel@localhost.localdomain> Sender: linux-security-module-owner@vger.kernel.org To: Eric Paris Cc: LSM , Casey Schaufler , linux-audit@redhat.com, Linux Kernel Mailing List , sgrubb@redhat.com, sds@tycho.nsa.gov List-Id: linux-audit@redhat.com Eric Paris wrote: > On Sun, 2009-04-05 at 10:46 +0200, Etienne Basset wrote: > >> the following 2 patches implements auditing of security events for Smack. >> It tries to implement what Eric Paris suggested, and moves shareable code >> to include/linux/lsm_audit.h and security/lsm_audit.c. >> Smack specific logging functions are now defined in smack_access.c > > >> type=1400 audit(1238919813.116:21): SMACK[smack_inode_getattr]: action=denied subject="FOO" object="etienne" requested=r pid=6679 comm="bash" path="/home/etienne/Desktop" dev=sda8ino=1237000 > > Can we make SMACK[smack_inode_getarr] into key=value pairs too and get > rid of that extra ':'? Anyone have naming suggestions? > > lsm=SMACK function=smack_inode_getattr > yes, sure. Maybe just : lsm=SMACK fn=smack_inode_getattr I want as much info as possible with as less characters as possible (is this english? :) ) > also: dev=sda8ino=1237000 I'm guessing that was just a typo of you > putting the example into the e-mail, but you may want to double check. > yeah, bad cut&paste, sorry about that Etienne