From mboxrd@z Thu Jan 1 00:00:00 1970 From: Etienne Basset Subject: Re: [PATCH 1/2] security/smack implement logging V3 Date: Mon, 13 Apr 2009 21:41:39 +0200 Message-ID: <49E39573.8020300@numericable.fr> References: <49DCEF6C.80600@numericable.fr> <1239648913.4320.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1239648913.4320.6.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Eric Paris Cc: LSM , linux-audit@redhat.com List-Id: linux-audit@redhat.com Eric Paris wrote: > On Wed, 2009-04-08 at 20:39 +0200, Etienne Basset wrote: >> This patch creates auditing functions usable by LSM to audit security >> events. It provides standard dumping of FS, NET, task etc ... events >> (code borrowed from SELinux) >> and provides 2 callbacks to define LSM specific auditing, which should be >> flexible enough to convert SELinux too. >> >> Signed-off-by: Etienne Basset > > Acked-by: Eric Paris > thanks! > Not worth doing another round, but if you do: > > common_audit_data->function is (I think) SMACK specific, and probably > should live in the smack private union. > Yes, sure, but they also could use it. (i find it quite convenient) thanks Etienne