From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH] audit: fix build error when disable audit Date: Fri, 20 Dec 2013 10:26:16 +0800 Message-ID: <52B3AAC8.6040206@cn.fujitsu.com> References: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> <52B25CA8.8090806@cn.fujitsu.com> <20131220011956.GA14944@madcap2.tricolour.ca> <52B39FEB.8030308@cn.fujitsu.com> <20131220014007.GD14944@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20131220014007.GD14944@madcap2.tricolour.ca> Sender: linux-kernel-owner@vger.kernel.org To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org List-Id: linux-audit@redhat.com On 12/20/2013 09:40 AM, Richard Guy Briggs wrote: > On 13/12/20, Gao feng wrote: >> On 12/20/2013 09:19 AM, Richard Guy Briggs wrote: >>> On 13/12/19, Gao feng wrote: >>>> On 12/19/2013 10:34 AM, Gao feng wrote: >>>>> kernel/capability.c: In function =E2=80=98SYSC_capset=E2=80=99: >>>>> kernel/capability.c:280:2: warning: passing argument 1 of =E2=80=98= audit_log_capset=E2=80=99 makes integer from pointer without a cast [en= abled by default] >>>>> audit_log_capset(new, current_cred()); >>>>> ^ >>>>> In file included from kernel/capability.c:10:0: >>>>> include/linux/audit.h:400:20: note: expected =E2=80=98pid_t=E2=80= =99 but argument is of type =E2=80=98struct cred *=E2=80=99 >>>>> static inline void audit_log_capset(pid_t pid, const struct cred= *new, >>>>> ^ >>>>> kernel/capability.c:280:2: error: too few arguments to function =E2= =80=98audit_log_capset=E2=80=99 >>>>> audit_log_capset(new, current_cred()); >>>>> ^ >>>>> In file included from kernel/capability.c:10:0: >>>>> include/linux/audit.h:400:20: note: declared here >>>>> static inline void audit_log_capset(pid_t pid, const struct cred= *new, >>>>> ^ >>>>> make[1]: *** [kernel/capability.o] Error 1 >>>> >>>> BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd7= 85f65 >>>> audit: Simplify and correct audit_log_capset >>> >>> Yup, found it. Thanks for the patch. Since it isn't upstream yet,= I >>> may merge it and rebase for linux-next. >> >> thank you Richard, btw, do you have plan to push these changes to th= e linux-next? >=20 > Yes, that's where I'm putting all these, via Eric. >=20 get it, thanks!