From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Subject: Re: [PATCH v2 3/3] audit(userspace): Add compat system call support for AArch64 Date: Mon, 20 Jan 2014 14:05:10 +0900 Message-ID: <52DCAE86.3090900@linaro.org> References: <1384846140-5716-1-git-send-email-takahiro.akashi@linaro.org> <1389946529-4590-1-git-send-email-takahiro.akashi@linaro.org> <1389946529-4590-4-git-send-email-takahiro.akashi@linaro.org> <20140117150522.GJ16003@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com [10.5.110.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0K55JdO018129 for ; Mon, 20 Jan 2014 00:05:19 -0500 Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0K55IDT006508 for ; Mon, 20 Jan 2014 00:05:18 -0500 Received: by mail-pb0-f41.google.com with SMTP id up15so6034268pbc.0 for ; Sun, 19 Jan 2014 21:05:18 -0800 (PST) In-Reply-To: <20140117150522.GJ16003@mudshark.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Will Deacon Cc: "linux-audit@redhat.com" , "arndb@arndb.de" , "patches@linaro.org" List-Id: linux-audit@redhat.com [+ Cc: Eric] On 01/18/2014 12:05 AM, Will Deacon wrote: > On Fri, Jan 17, 2014 at 08:15:29AM +0000, AKASHI Takahiro wrote: >> For 32-bit task auditing (-F arch=b32), internally-used machine type will >> be overwritten to MACH_ARM[EB] in order to use a correct system call >> lookup table. >> >> Signed-off-by: AKASHI Takahiro >> --- >> lib/libaudit.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/lib/libaudit.c b/lib/libaudit.c >> index 77b3f9b..df2af2a 100644 >> --- a/lib/libaudit.c >> +++ b/lib/libaudit.c >> @@ -1306,6 +1306,12 @@ int audit_rule_fieldpair_data(struct audit_rule_data **rulep, const char *pair, >> else if (bits == ~__AUDIT_ARCH_64BIT && >> machine == MACH_S390X) >> machine = MACH_S390; >> + else if (bits == ~__AUDIT_ARCH_64BIT && >> + machine == MACH_AARCH64) >> + machine = MACH_ARM; >> + else if (bits == ~__AUDIT_ARCH_64BIT && >> + machine == MACH_AARCH64EB) >> + machine = MACH_ARMEB; > > Why do you care about MACH_ARMEB? The syscall APIs are identical for either > endianness. Yeah, I remember that you have already mentioned it before: On 11/08/2013 11:34 PM, Will Deacon wrote: > On Wed, Nov 06, 2013 at 10:25:42AM +0000, AKASHI Takahiro wrote: >> * Userspace audit package >> There are some missing syscall definitions in lib/aarch64_table.h. >> There is no support for AUDIT_ARCH_ARM (I mean LE. armeb is BE). > > I did post something over a year ago... did it not get picked up? > > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/165266 But since then, I've never got any follow-ups from audit folks (especially Eric) and so just kept the code unchanged and made my changes compatible with it. Once we all agree, I will be easily able to remove such a conditional. -Takahiro AKASHI > Will >