From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Subject: Re: [PATCH v6 2/2] arm64: audit: Add audit hook in ptrace/syscall_trace Date: Thu, 06 Mar 2014 11:10:19 +0900 Message-ID: <5317D90B.3020606@linaro.org> References: <1393319934-2810-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> <20140228161558.GE29546@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140228161558.GE29546@mudshark.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Catalin Marinas , "dsaxena@linaro.org" , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" List-Id: linux-audit@redhat.com On 03/01/2014 01:15 AM, Will Deacon wrote: > On Fri, Feb 28, 2014 at 05:17:15AM +0000, AKASHI Takahiro wrote: >> This patch adds auditing functions on entry to or exit from >> every system call invocation. >> >> Acked-by: Richard Guy Briggs >> Signed-off-by: AKASHI Takahiro >> --- >> arch/arm64/kernel/ptrace.c | 54 ++++++++++++++++++++++++++------------------ >> 1 file changed, 32 insertions(+), 22 deletions(-) > > I think you need to do something like I did for arch/arm/, where we have > separate trace functions for entry/exit to make sure that we invoke the > various helpers in the correct order (for example, you want to invoke all > the debug stuff *first* on entry, but *last* on exit). > > Will > If you mean syscall_trace_enter()/exit(), I will follow your suggestion for readability. -Takahiro AKASHI