From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [RFC PATCH 3/7] audit: allow systemd to use queue reserves Date: Thu, 22 Oct 2015 15:26:58 -0400 Message-ID: <5338619.9WBiI2UOhk@x2> References: <5292b00da892ca8cedff9d31ecda132ad384b035.1445539473.git.rgb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5292b00da892ca8cedff9d31ecda132ad384b035.1445539473.git.rgb@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thursday, October 22, 2015 02:53:16 PM Richard Guy Briggs wrote: > Treat systemd the same way as auditd, allowing it to overrun the queue to > avoid blocking. Do you mind explaining this a little more? I'm having a hard time understanding how systemd is involved. -Steve > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 3917aad..384a1a1 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1375,7 +1375,7 @@ struct audit_buffer *audit_log_start(struct > audit_context *ctx, gfp_t gfp_mask, return NULL; > > if (gfp_mask & __GFP_WAIT) { > - if (audit_pid && audit_pid == current->tgid) > + if (current->tgid == 1 || (audit_pid && audit_pid == current->tgid)) > gfp_mask &= ~__GFP_WAIT; > else > reserve = 0;