Re: [PATCH][v6] netlink: have netlink per-protocol bind function return an error code.

David Miller
2014-03-26T20:46:00Z

From: Richard Guy Briggs <rgb@redhat.com>
Date: Tue, 25 Mar 2014 08:50:56 -0400

> @@ -1441,6 +1445,24 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
> if (!nladdr->nl_groups && (nlk->groups == NULL || !(u32)nlk->groups[0]))
> return 0;
>
> + if (nlk->netlink_bind && nladdr->nl_groups) {
> + int i;
> +
> + for (i = 0; i < nlk->ngroups; i++)
...
> + if (err) {
> + int undo;
> + if (!nlk->portid)
> + netlink_remove(sk);

Please put an empty line between local variable declarations and code, just as it
is a few lines up.