From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3701CC4361A for ; Fri, 4 Dec 2020 02:49:48 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE3CE221E3 for ; Fri, 4 Dec 2020 02:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE3CE221E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607050186; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9Ym7//Elw49vibG9lP5ltWagdastzhxZQY5ZUAA47Nc=; b=RwQLauioFvK8TJzzFmGY5Hep7CS/SADujNLsApVkF9olhDhfray356qHbEPw/qSUV/LEOj TyzlqToe3lZywhwiMXm0JOm3DjSllP810jVfYDxB67NpjmFypji0V683MBPY1zTKwbQSIG fhaBc3lSf/pY6P5qKDszF9d7BvdY9Ks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-WqQ1SzzBNX6c0ngozdVlzw-1; Thu, 03 Dec 2020 21:49:44 -0500 X-MC-Unique: WqQ1SzzBNX6c0ngozdVlzw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C90591800D41; Fri, 4 Dec 2020 02:49:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 046425D9CA; Fri, 4 Dec 2020 02:49:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4D06F4A7C6; Fri, 4 Dec 2020 02:49:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B42ln20006941 for ; Thu, 3 Dec 2020 21:47:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7E3BA6085A; Fri, 4 Dec 2020 02:47:49 +0000 (UTC) Received: from x2.localnet (ovpn-112-13.rdu2.redhat.com [10.10.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 104C360854; Fri, 4 Dec 2020 02:47:42 +0000 (UTC) From: Steve Grubb To: Paul Moore Subject: Re: [PATCH v2] audit: report audit wait metric in audit status reply Date: Thu, 03 Dec 2020 21:47:40 -0500 Message-ID: <5413598.DvuYhMxLoT@x2> Organization: Red Hat In-Reply-To: References: <20200701213244.GA1817@linux-kernel-dev> <20883376.EfDdHjke4D@x2> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: linux-audit@redhat.com Cc: Richard Guy Briggs , linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thursday, December 3, 2020 9:16:52 PM EST Paul Moore wrote: > > > > Author: Richard Guy Briggs > > > > AuthorDate: 2014-11-17 15:51:01 -0500 > > > > Commit: Paul Moore > > > > CommitDate: 2014-11-17 16:53:51 -0500 > > > > ("audit: convert status version to a feature bitmap") > > > > It was introduced specifically to enable distributions to selectively > > > > backport features. It was converted away from AUDIT_VERSION. > > > > > > > > There are other ways to detect the presence of > > > > backlog_wait_time_actual > > > > as I mentioned above. > > > > > > Let me be blunt - I honestly don't care what Steve's audit userspace > > > does to detect this. I've got my own opinion, but Steve's audit > > > userspace is not my project to manage and I think we've established > > > over the years that Steve and I have very different views on what > > > constitutes good design. > > > > And guessing what might be in buffers of different sizes is good design? > > The FEATURE_BITMAP was introduced to get rid of this ambiguity. > > There is just soo much to unpack in your comment Steve, but let me > keep it short ... > > - This is an enterprise distro problem, not an upstream problem. The > problems you are talking about are not a problem for upstream. You may look at it that way. I do not. Audit -userspace is also an upstream for a lot of distros and I need to make this painless for them. So, while you may think of this being a backport problem for Red Hat to solve, I think of this as a generic problem that I'd like to solve for Debian, Suse, Ubuntu, Arch, Gentoo, anyone using audit. We both are upstream. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit