From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D7EC4361B for ; Tue, 8 Dec 2020 03:34:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 034B523A5B for ; Tue, 8 Dec 2020 03:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 034B523A5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607398478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KvMjbmNCtJscPddeZgm+ILqranL2glF8CtB9/Y/5NYc=; b=RiM3SyG1laWS1ot+QZblKPkwWG2vvzHakTjRs2L65ryVQvKHpy0CYqbm64NuoVG+AT/t26 FYWuZUi2sHPLcEojr+i2HkUkyWkxW9SJ2ZWgomk2/4sTG20ciFVIU0CUDf47CxJ5NWqE89 r8vBgcVZxY42NLOXRyxbvtLttW3skKU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-0B1itHPhNfSR0IryBOqYfw-1; Mon, 07 Dec 2020 22:34:36 -0500 X-MC-Unique: 0B1itHPhNfSR0IryBOqYfw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9A4610054FF; Tue, 8 Dec 2020 03:34:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FA3D5D6AB; Tue, 8 Dec 2020 03:34:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80B424BB7B; Tue, 8 Dec 2020 03:34:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B83YR0K023792 for ; Mon, 7 Dec 2020 22:34:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 176C05D9E2; Tue, 8 Dec 2020 03:34:27 +0000 (UTC) Received: from x2.localnet (ovpn-112-212.rdu2.redhat.com [10.10.112.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id A80D85D9DE; Tue, 8 Dec 2020 03:34:20 +0000 (UTC) From: Steve Grubb To: Richard Guy Briggs Subject: Re: [PATCH v2] audit: report audit wait metric in audit status reply Date: Mon, 07 Dec 2020 22:34:17 -0500 Message-ID: <5414845.DvuYhMxLoT@x2> Organization: Red Hat In-Reply-To: <20201208013435.GU1762914@madcap2.tricolour.ca> References: <20200701213244.GA1817@linux-kernel-dev> <2046910.irdbgypaU6@x2> <20201208013435.GU1762914@madcap2.tricolour.ca> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Monday, December 7, 2020 8:34:35 PM EST Richard Guy Briggs wrote: > On 2020-12-07 18:28, Steve Grubb wrote: > > Hello Max, > > > > On Monday, December 7, 2020 4:28:14 PM EST Max Englander wrote: > > > Steve, I'm happy to make changes to the userspace PR based on > > > Richard's suggestions, if that sounds good to you. I'll follow up in > > > the PR to discuss it more > > > > The only issue is new userspace on old kernel. I think if we use both the > > configure macro in addition to a size check, then it will at least allow > > forward and backward compatibility. > > Are you talking about a new userspace compiled on a new kernel header > file run on an old kernel? Yes. This is my worry. Someone compiles the code and the does a roll back. It can happen because the new kernel has some problems that a driver cannot handle. > That would be less reliable and need the > size check. The bitmap would be the most reliable in that scenario. Right, but the person that can make that happen doesn't want to use this facility for what it was intended for. So, we are all trying to do the best. > By configure macro are you talking about the presence of that audit > status mask bit, or the presence of that struct audit_status member? Yes. But it doesn't apply to old kernels. -Steve -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit