From: Arnd Bergmann <arnd@arndb.de>
To: linaro-kernel@lists.linaro.org
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
viro@zeniv.linux.org.uk, eparis@redhat.com, rgb@redhat.com,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, linux-audit@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 1/3] arm64: Add __NR_* definitions for compat syscalls
Date: Fri, 04 Jul 2014 12:06:07 +0200 [thread overview]
Message-ID: <5418828.mxvNk2rT0e@wuerfel> (raw)
In-Reply-To: <1404458911-8214-2-git-send-email-takahiro.akashi@linaro.org>
On Friday 04 July 2014 16:28:29 AKASHI Takahiro wrote:
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> This patch adds __NR_* definitions to asm/unistd32.h, moves the
> __NR_compat_* definitions to asm/unistd.h and removes all the explicit
> unistd32.h includes apart from the one building the compat syscall
> table. The aim is to have the compat __NR_* definitions available but
> without colliding with the native syscall definitions.
>
> And adds more syscall definitions for 3.16.
Can you explain in more detail why you want to add those macros? I've
looked at all three patches in the series but can't find any code using
them.
I would expect that we don't need to define those macros at all for
compat mode, since they are meant primarily for user space (glibc)
compilation, which gets them from arch/arm/include/asm/unistd.h.
Arnd
next prev parent reply other threads:[~2014-07-04 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 7:28 [PATCH v10 0/3] arm64: Add audit support AKASHI Takahiro
2014-07-04 7:28 ` [PATCH v10 1/3] arm64: Add __NR_* definitions for compat syscalls AKASHI Takahiro
2014-07-04 10:06 ` Arnd Bergmann [this message]
2014-07-04 10:57 ` Catalin Marinas
2014-07-04 11:05 ` AKASHI Takahiro
2014-07-04 11:17 ` Arnd Bergmann
2015-01-28 21:31 ` Timur Tabi
2015-01-28 21:35 ` Arnd Bergmann
2015-01-29 9:57 ` Will Deacon
2014-07-04 7:28 ` [PATCH v10 2/3] arm64: Add audit support AKASHI Takahiro
2014-07-04 7:28 ` [PATCH v10 3/3] arm64: audit: Add audit hook in syscall_trace_enter/exit() AKASHI Takahiro
2014-07-10 10:08 ` [PATCH v10 0/3] arm64: Add audit support Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418828.mxvNk2rT0e@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=eparis@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=takahiro.akashi@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox