linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Scott Matheina <scott@matheina.com>
To: Paul Moore <paul@paul-moore.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] Fix to:WARNING: please, no space before tabs modified: kernel/auditfilter.c
Date: Mon, 26 Oct 2015 18:02:52 -0500	[thread overview]
Message-ID: <562EB11C.1010005@matheina.com> (raw)
In-Reply-To: <CAHC9VhRczO=dh=94+SqunfcoDfkZQ1KoGsBUK035hKkfayjU9Q@mail.gmail.com>



On 10/26/15 3:07 PM, Paul Moore wrote:
> On Sunday, October 25, 2015 09:00:49 PM Scott Matheina wrote:
>> Signed-off-by: Scott Matheina <scott@matheina.com>
>> ---
>>   kernel/auditfilter.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
> [NOTE: Adding the linux-audit list to the CC line]
>
> Applied, but I modified the patch subject line to "audit: fix comment block
> whitespace" as the original was a bit verbose.  You can check the mailing list
> archive, or the git log, to see what people typically use for patch subject
> lines.

Thanks!

>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 7714d93..b8ff9e1 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -39,13 +39,13 @@
>>    * Locking model:
>>    *
>>    * audit_filter_mutex:
>> - * Synchronizes writes and blocking reads of audit's filterlist
>> - * data.  Rcu is used to traverse the filterlist and access
>> - * contents of structs audit_entry, audit_watch and opaque
>> - * LSM rules during filtering.  If modified, these structures
>> - * must be copied and replace their counterparts in the filterlist.
>> - * An audit_parent struct is not accessed during filtering, so may
>> - * be written directly provided audit_filter_mutex is held.
>> + * Synchronizes writes and blocking reads of audit's filterlist
>> + * data.  Rcu is used to traverse the filterlist and access
>> + * contents of structs audit_entry, audit_watch and opaque
>> + * LSM rules during filtering.  If modified, these structures
>> + * must be copied and replace their counterparts in the filterlist.
>> + * An audit_parent struct is not accessed during filtering, so may
>> + * be written directly provided audit_filter_mutex is held.
>>    */
>>
>>   /* Audit filter lists, defined in <linux/audit.h> */

      reply	other threads:[~2015-10-26 23:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1445824849-4089-1-git-send-email-scott@matheina.com>
2015-10-26 20:07 ` [PATCH] Fix to:WARNING: please, no space before tabs modified: kernel/auditfilter.c Paul Moore
2015-10-26 23:02   ` Scott Matheina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562EB11C.1010005@matheina.com \
    --to=scott@matheina.com \
    --cc=linux-audit@redhat.com \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).