Re: [PATCH] Fix to:WARNING: please, no space before tabs modified: kernel/auditfilter.c

Re: [PATCH] Fix to:WARNING: please, no space before tabs modified: kernel/auditfilter.c

[Paul Moore]

On Sunday, October 25, 2015 09:00:49 PM Scott Matheina wrote:
> Signed-off-by: Scott Matheina <scott@matheina.com>
> ---
>  kernel/auditfilter.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

[NOTE: Adding the linux-audit list to the CC line]

Applied, but I modified the patch subject line to "audit: fix comment block
whitespace" as the original was a bit verbose.  You can check the mailing list
archive, or the git log, to see what people typically use for patch subject
lines.

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 7714d93..b8ff9e1 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -39,13 +39,13 @@
>   * Locking model:
>   *
>   * audit_filter_mutex:
> - * Synchronizes writes and blocking reads of audit's filterlist
> - * data.  Rcu is used to traverse the filterlist and access
> - * contents of structs audit_entry, audit_watch and opaque
> - * LSM rules during filtering.  If modified, these structures
> - * must be copied and replace their counterparts in the filterlist.
> - * An audit_parent struct is not accessed during filtering, so may
> - * be written directly provided audit_filter_mutex is held.
> + * Synchronizes writes and blocking reads of audit's filterlist
> + * data.  Rcu is used to traverse the filterlist and access
> + * contents of structs audit_entry, audit_watch and opaque
> + * LSM rules during filtering.  If modified, these structures
> + * must be copied and replace their counterparts in the filterlist.
> + * An audit_parent struct is not accessed during filtering, so may
> + * be written directly provided audit_filter_mutex is held.
>   */
>
>  /* Audit filter lists, defined in <linux/audit.h> */

-- 
paul moore
www.paul-moore.com

Re: [PATCH] Fix to:WARNING: please, no space before tabs modified: kernel/auditfilter.c

[Scott Matheina]

On 10/26/15 3:07 PM, Paul Moore wrote:
> On Sunday, October 25, 2015 09:00:49 PM Scott Matheina wrote:
>> Signed-off-by: Scott Matheina <scott@matheina.com>
>> ---
>>   kernel/auditfilter.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
> [NOTE: Adding the linux-audit list to the CC line]
>
> Applied, but I modified the patch subject line to "audit: fix comment block
> whitespace" as the original was a bit verbose.  You can check the mailing list
> archive, or the git log, to see what people typically use for patch subject
> lines.

Thanks!

>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 7714d93..b8ff9e1 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -39,13 +39,13 @@
>>    * Locking model:
>>    *
>>    * audit_filter_mutex:
>> - * Synchronizes writes and blocking reads of audit's filterlist
>> - * data.  Rcu is used to traverse the filterlist and access
>> - * contents of structs audit_entry, audit_watch and opaque
>> - * LSM rules during filtering.  If modified, these structures
>> - * must be copied and replace their counterparts in the filterlist.
>> - * An audit_parent struct is not accessed during filtering, so may
>> - * be written directly provided audit_filter_mutex is held.
>> + * Synchronizes writes and blocking reads of audit's filterlist
>> + * data.  Rcu is used to traverse the filterlist and access
>> + * contents of structs audit_entry, audit_watch and opaque
>> + * LSM rules during filtering.  If modified, these structures
>> + * must be copied and replace their counterparts in the filterlist.
>> + * An audit_parent struct is not accessed during filtering, so may
>> + * be written directly provided audit_filter_mutex is held.
>>    */
>>
>>   /* Audit filter lists, defined in <linux/audit.h> */