From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92F8C433F5 for ; Thu, 28 Oct 2021 21:15:02 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56D10610A4 for ; Thu, 28 Oct 2021 21:15:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 56D10610A4 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635455701; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ngvrd/X+Q3u5lJPA1aXP0Vea+DKV9lJFnat4NfAywkI=; b=NmZt4pLXfZSRCF23QOcqGGxIBE4oAm8o0ChSpVfduSY6PUqTwZGukaQjD62GpryVCJ4Y6S 4qI9fCUK8qpUxew4WcKsJFtSHRklw5Xob/jE4Edj9ZEsw7tCtKttbTtBT8WGnJI6BwE1Um 4SILZdk6g3rVkBIcg4B9hFNsMHwN334= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-IIVyG6t-NxSNiwUxspJrIA-1; Thu, 28 Oct 2021 17:14:57 -0400 X-MC-Unique: IIVyG6t-NxSNiwUxspJrIA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A3DE10A8E01; Thu, 28 Oct 2021 21:14:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56E4B100EBBE; Thu, 28 Oct 2021 21:14:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 261E74A704; Thu, 28 Oct 2021 21:14:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19SLEru0026938 for ; Thu, 28 Oct 2021 17:14:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 620CB18174; Thu, 28 Oct 2021 21:14:53 +0000 (UTC) Received: from x2.localnet (unknown [10.22.33.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59B20ADCB; Thu, 28 Oct 2021 21:14:43 +0000 (UTC) From: Steve Grubb To: Linux-Audit Mailing List , Richard Guy Briggs Subject: Re: [PATCH v1] auditctl: check for a watch before adding perm Date: Thu, 28 Oct 2021 17:14:43 -0400 Message-ID: <5631519.DvuYhMxLoT@x2> Organization: Red Hat In-Reply-To: <20211028194857.3100986-1-rgb@redhat.com> References: <20211028194857.3100986-1-rgb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thursday, October 28, 2021 3:48:57 PM EDT Richard Guy Briggs wrote: > The existing check would never trigger since add and del are defaulted to > AUDIT_FILTER_UNSET which is not zero. Thanks! Applied. -Steve > Signed-off-by: Richard Guy Briggs > --- > src/auditctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/auditctl.c b/src/auditctl.c > index ca6905b2884e..06bb747c5fd2 100644 > --- a/src/auditctl.c > +++ b/src/auditctl.c > @@ -1020,7 +1020,7 @@ process_keys: > } > break; > case 'p': > - if (!add && !del) { > + if (add == AUDIT_FILTER_UNSET && del == AUDIT_FILTER_UNSET) { > audit_msg(LOG_ERR, > "permission option needs a watch given prior to it"); > retval = -1; -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit